Skip to content

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
  • Loading branch information
bmino committed Mar 19, 2020
2 parents 14aa2c1 + dddb555 commit e297557
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "binance-triangle-arbitrage",
"version": "5.2.6",
"version": "5.2.7",
"repository": {
"type": "git",
"url": "https://github.com/bmino/binance-triangle-arbitrage.git"
Expand Down
2 changes: 1 addition & 1 deletion src/main/ArbitrageExecution.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const ArbitrageExecution = {
ArbitrageExecution.inProgressSymbols.delete(symbol.c);

if (CONFIG.TRADING.EXECUTION_CAP && ArbitrageExecution.inProgressIds.size === 0 && ArbitrageExecution.getAttemptedPositionsCount() >= CONFIG.TRADING.EXECUTION_CAP) {
logger.execution.fatal(`Cannot exceed user defined execution cap of ${CONFIG.TRADING.EXECUTION_CAP} executions`);
logger.execution.info(`Cannot exceed user defined execution cap of ${CONFIG.TRADING.EXECUTION_CAP} executions`);
process.exit();
}
});
Expand Down
4 changes: 2 additions & 2 deletions src/main/CalculationNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ const CalculationNode = {
return amountTo + (amountFrom * rate);
}
}
throw new Error(`Bid depth (${bidRates.length}) too shallow to reverse convert ${amountFrom} ${symbolFrom} to ${symbolTo} using ${ticker}`);
throw new Error(`Bid depth (${bidRates.length}) too shallow to convert ${amountFrom} ${symbolFrom} to ${symbolTo} using ${ticker}`);
} else {
for (i=0; i<askRates.length; i++) {
rate = parseFloat(askRates[i]);
Expand All @@ -167,7 +167,7 @@ const CalculationNode = {
return amountTo + (amountFrom / rate);
}
}
throw new Error(`Ask depth (${askRates.length}) too shallow to reverse convert ${amountFrom} ${symbolFrom} to ${symbolTo} using ${ticker}`);
throw new Error(`Ask depth (${askRates.length}) too shallow to convert ${amountFrom} ${symbolFrom} to ${symbolTo} using ${ticker}`);
}
},

Expand Down

2 comments on commit e297557

@ognanvo
Copy link

@ognanvo ognanvo commented on e297557 Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ognanvo@OptiPlex-780:~/binance-triangle-arbitrage-5.2.7$ npm start

[email protected] start /home/ognanvo/binance-triangle-arbitrage-5.2.7
node src/main/Main.js

internal/modules/cjs/loader.js:1195
throw err;
^

SyntaxError: /home/ognanvo/binance-triangle-arbitrage-5.2.7/config/config.json: Unexpected token j in JSON at position 32
at parse ()
at Object.Module._extensions..json (internal/modules/cjs/loader.js:1192:22)
at Module.load (internal/modules/cjs/loader.js:1002:32)
at Function.Module._load (internal/modules/cjs/loader.js:901:14)
at Module.require (internal/modules/cjs/loader.js:1044:19)
at require (internal/modules/cjs/helpers.js:77:18)
at Object. (/home/ognanvo/binance-triangle-arbitrage-5.2.7/src/main/Main.js:1:16)
at Module._compile (internal/modules/cjs/loader.js:1158:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
at Module.load (internal/modules/cjs/loader.js:1002:32)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: node src/main/Main.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR! /home/ognanvo/.npm/_logs/2020-04-06T22_04_49_766Z-debug.log

@ognanvo
Copy link

@ognanvo ognanvo commented on e297557 Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I am not a developer, but I followed to the letter the tutorial of installation of the bot, but I cannot manage to make it run on my pc linux ubuntu 18.
I thank your help please

Please sign in to comment.