Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bmorris3,
first of all, thanks for this nicely documented lean piece of programming! fleck turns out to work great with flares, too! While trying out the software, I stumbled over a few small issues, mostly cosmetic, which I suggest incorporating in a future of release of fleck:
First, I suggest, bumping up fleck to at least Python 3.8.
Second, I suggest following adjustments to
core.py
:np.int
>>>np.int32
to remove a deprecation warning from numpyself.phases[:, np.newaxis, np.newaxis]
>>>self.phases[..., np.newaxis, np.newaxis]
so that fleck works with higher dimensional input (e.g., if accommodating dynamic flaring regions instead of static spots)inc_stellar
from rad to deg ingenerate_spots
to make it more consistent with input variables that are given in deg, e.g.min_latitude
andmax_latitude
.generate_spots
because that, for some reason, does not work with astropy units (this is something a have seen failing in one of the recent travis runs, so I don't think that's a local issue)Cheers, Ekaterina