Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and a bug? #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ekaterinailin
Copy link

@ekaterinailin ekaterinailin commented Jan 1, 2022

Hi @bmorris3,

first of all, thanks for this nicely documented lean piece of programming! fleck turns out to work great with flares, too! While trying out the software, I stumbled over a few small issues, mostly cosmetic, which I suggest incorporating in a future of release of fleck:

First, I suggest, bumping up fleck to at least Python 3.8.

Second, I suggest following adjustments to core.py:

  • np.int >>> np.int32 to remove a deprecation warning from numpy
  • self.phases[:, np.newaxis, np.newaxis] >>> self.phases[..., np.newaxis, np.newaxis] so that fleck works with higher dimensional input (e.g., if accommodating dynamic flaring regions instead of static spots)
  • convert inc_stellar from rad to deg in generate_spots to make it more consistent with input variables that are given in deg, e.g. min_latitude and max_latitude.
  • removing inplace multiplication in generate_spots because that, for some reason, does not work with astropy units (this is something a have seen failing in one of the recent travis runs, so I don't think that's a local issue)

Cheers, Ekaterina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant