fix(network): guard empty buffer in UpgradeStatusExtension::decode#399
Open
mark0-cn wants to merge 1 commit into
Open
fix(network): guard empty buffer in UpgradeStatusExtension::decode#399mark0-cn wants to merge 1 commit into
mark0-cn wants to merge 1 commit into
Conversation
The BSC handshake decodes a peer-controlled buffer, but `decode` indexed `buf[0]` without an emptiness check, so a truncated/empty UpgradeStatus message panicked the connection task — any peer could trigger it. Guard `buf.is_empty()` and return `InputTooShort`, matching the sibling `BscCapPacket::decode`.
Pull Request ReviewThis PR fixes a panic condition in the Rust P2P handshake decoder by adding an Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The BSC handshake decodes a peer-controlled buffer into
UpgradeStatusExtension, butUpgradeStatusExtension::decode(src/node/network/upgrade_status.rs) indexedbuf[0]without an emptiness check. A truncated or emptyUpgradeStatusmessage therefore panics the connection/handshake task with an index-out-of-bounds — and the buffer comes straight off the wire during the handshake, so any peer can trigger it.The sibling
BscCapPacket::decodealready guardsbuf.is_empty()and returnsalloy_rlp::Error::InputTooShort; this applies the same guard here.Added a regression test asserting that decoding an empty buffer returns
Errinstead of panicking.