Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Bugfix for internal links. #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix for internal links. #21

wants to merge 1 commit into from

Conversation

gabyx
Copy link

@gabyx gabyx commented Jun 19, 2019

This code corrects the bugs associated with #20 .

  • I removed the code which handles some weird behavior when going to a previous slide.
  • Made the focusFragements callbacks more symmetrical
  • This works. Maybe we should make my changes more robust (javascript juhee....)

bnjmnt4n added a commit that referenced this pull request Aug 10, 2019
@bnjmnt4n
Ensure that lines are focused based on the current…
9a2002d 
…fragment when slides are changed.

This removes code that previously incorrectly manipulated fragments when
navigating to a prior slide.

Closes #20, #21.
bnjmnt4n added a commit that referenced this pull request Aug 11, 2019
@bnjmnt4n
Ensure that navigation between different fragments…
ef346fb 
…works accurately.

When navigating from 1 fragment to another while skipping fragments in
between, the 'fragmentshown' and 'fragmenthidden' event handlers will
include all fragments in between. This commit modifies the handler code
to only focus on lines from the relevant fragments.

Closes #20, #21.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabyx