-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compatibility for python syntax in AST rewrite #249
Conversation
@@ -69,7 +102,7 @@ def visit_FunctionDef(self, node): | |||
name=node.name, | |||
args=node.args, | |||
body=prefix + node.body, | |||
decorator_list=node.decorator_list, | |||
decorator_list=decorator_list, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug fix: Since we need to remove init_pydough_context
, the updated deco list needs to be sent.
This PR modifies the AST visitor to support more python syntax. Here are examples of syntax that is supported now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic @vineetg3 !!! Just a few things before I'll approve.
Btw, make sure to include this comment of yours in the merge commit. These are FANTASTIC details to include. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolve #222