Add PyUpgrade and import cleaning to Ruff #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knassre-bodo
commented
Nov 5, 2024
| [tool.ruff] | ||
| unsafe-fixes = true | ||
| lint.extend-select = [ | ||
| "I", # isort |
There was a problem hiding this comment.
I also added the other ones we use in Bodo, bc I was kinda missing the clean imports :)
knassre-bodo
commented
Nov 5, 2024
| @@ -14,3 +14,12 @@ dev-dependencies = ["pre-commit", "pytest", "ruff==0.6.7"] | |||
| [build-system] | |||
| requires = ["hatchling"] | |||
| build-backend = "hatchling.build" | |||
|
|
|||
| [tool.ruff] | |||
| unsafe-fixes = true | |||
There was a problem hiding this comment.
Not 100% sure about this part, but copied that from Bodo
knassre-bodo
changed the title
njriasan
approved these changes
Nov 6, 2024
| @@ -72,7 +72,7 @@ def to_tree_form(self) -> CollectionTreeForm: | |||
| ) | |||
| item_str: str | |||
| if isinstance( | |||
| self.collection_access, (SubCollection, HiddenBackReferenceCollection) | |||
| self.collection_access, SubCollection | HiddenBackReferenceCollection | |||
There was a problem hiding this comment.
Srinivas opted to disable this inside Bodo because the tuple check is faster. I personally would like to disable that here as well.
| "UP", # pyupgrade | ||
| "C4", # flake8-comprehensions | ||
| "TID", # flake8-tidy-imports | ||
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ruff usage in the pre-commit hooks to use the PyUpgrade reformatting rules, as well as the rules that tidy up imports.