[BSE-4155] Add support for the Project relational node #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njriasan
commented
Nov 11, 2024
knassre-bodo
approved these changes
Nov 14, 2024
| from being generated. | ||
| """ | ||
|
|
||
| def __init__(self, value: Any, data_type: PyDoughType): |
There was a problem hiding this comment.
Should this be Any or object?
There was a problem hiding this comment.
These are equivalent. Everything inherits from object in Python. Personally I prefer Any.
Comment on lines
+32
to
+34
| def __hash__(self) -> int: | ||
| # Note: This will break if the value isn't hashable. | ||
| return hash((self.value, self.data_type)) |
There was a problem hiding this comment.
See my point in the Scan PR about hashing; would the string representation be sufficient?
An error occurred while trying to automatically change base from
nick/relational_scan
to
main
November 14, 2024 18:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the basic definition of the Project relational node.