[BSE-4155] Add support for the Root relational node #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knassre-bodo
approved these changes
Nov 14, 2024
pydough/relational/root.py
Outdated
| self, | ||
| input: Relational, | ||
| ordered_columns: MutableSequence[tuple[str, RelationalExpression]], | ||
| orderings: MutableSequence[ColumnOrdering] | None = None, |
There was a problem hiding this comment.
I don't think it should ever be None, though it could be empty. That way, the check for "do we need to insert an Order By" is just "is the list non-empty" (that could also go for Limit, which per our current design should never be empty or None).
There was a problem hiding this comment.
For convenience I was just making it possible to omit the argument if there is no required ordering. We may later want to remove this, but it's nice for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the basic definition of the Root relational node.