MySQL & Postgres image fix #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-sanchez31
commented
Oct 24, 2025
| # The first time, set up the defog data | ||
| import mysql.connector as mysql_connector | ||
|
|
||
| mysql_username = os.getenv("MYSQL_USERNAME") |
There was a problem hiding this comment.
This is not longer needed, defog is already included in the new image
| host=postgres_host, | ||
| port=postgres_port, | ||
| ) | ||
| connection.autocommit = True # It avoids getting stuck when DROP/CREATE |
There was a problem hiding this comment.
Same here, already included in the image
knassre-bodo
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustments in the waiting time in
conftest.py. This change allows local testing and ci use the new image for testing created with MySQL and Postgres workflow respectively.