Skip to content

MAINT: Cleanup with pythoncapi-compat#132

Merged
bodono merged 4 commits into
bodono:masterfrom
HaoZeke:cleanup
Jun 21, 2025
Merged

MAINT: Cleanup with pythoncapi-compat#132
bodono merged 4 commits into
bodono:masterfrom
HaoZeke:cleanup

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

Split from #131, and is a prerequisite for it.

  • Adds pythoncapi-compat (repo)
  • Corrected the test path to ignore tests in pythoncapi-compat
  • Updates scsobject.h with it
  • Renamed the scs submodule to match its path, i.e. scs_source
    • Also to be able to add pythoncapi-compat under scs

HaoZeke added a commit to HaoZeke/scs-python that referenced this pull request Jun 7, 2025
@bodono

bodono commented Jun 13, 2025

Copy link
Copy Markdown
Owner

Looks like there are a couple of conflicts now, let me know when you want me to merge this. Thanks again for taking it on!

@HaoZeke

HaoZeke commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

Looks like there are a couple of conflicts now, let me know when you want me to merge this. Thanks again for taking it on!

Thanks @bodono, this should be good to go (shortly followed by the final #131 :) )

@bodono

bodono commented Jun 21, 2025

Copy link
Copy Markdown
Owner

Thanks!

@bodono
bodono merged commit 3c44fae into bodono:master Jun 21, 2025
14 checks passed
@HaoZeke
HaoZeke deleted the cleanup branch July 4, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants