Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Action to annotate MAGs and contigs with AMRFinderPlus #88

Merged

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Jul 8, 2024

solves #87

Adds new action that can annotate MAGs and contigs.

Set up an environment

https://github.com/bokulich-lab/q2-amr?tab=readme-ov-file#installation

Run it locally

  1. First, clone the repo and checkout the PR branch:
git clone https://github.com/bokulich-lab/q2-amr.git
cd q2-amr
git fetch origin pull/87/head:pr-87
git checkout pr-87
pip install -e .
  1. Download test files
    PR-88.zip

  2. Test it out!

qiime amr fetch-amrfinderplus-db --o-amrfinderplus-db amrfinderplus_db.qza 
qiime amr annotate-sample-data-amrfinderplus --i-sequences test_mags.qza --output-dir output_mags --i-amrfinderplus-db amrfinderplus_db.qza --p-plus --p-curated-ident --p-organism "Escherichia" --p-report-all-equal --p-coverage-min 0.4 --p-translation-table "11"
qiime amr annotate-sample-data-amrfinderplus --i-sequences test_contigs.qza --output-dir output_contigs --i-amrfinderplus-db amrfinderplus_db.qza --p-plus --p-curated-ident --p-organism "Escherichia" --p-report-all-equal --p-coverage-min 0.4 --p-translation-table "11"

@VinzentRisch VinzentRisch force-pushed the 87_annotate_mags_amrfinderplus branch from ae7b8ba to bff9595 Compare July 16, 2024 14:04
@VinzentRisch VinzentRisch changed the title ENH: Action to annotate MAGs with AMRFinderPlus ENH: Action to annotate MAGs and contigs with AMRFinderPlus Jul 16, 2024
@VinzentRisch VinzentRisch marked this pull request as ready for review July 16, 2024 15:07
@VinzentRisch VinzentRisch requested review from a team and ChristosMatzoros and removed request for a team July 16, 2024 15:08
Copy link
Collaborator

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinzentRisch it works as expected! Have a look at my comments for some minor changes.

Copy link
Collaborator

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinzentRisch , seems good to me!

@VinzentRisch VinzentRisch merged commit 41bae5e into bokulich-lab:main Jul 17, 2024
2 checks passed
VinzentRisch added a commit to VinzentRisch/q2-rgi that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants