Skip to content

feat: add CommonOptions so all prompts accept a custom output/input #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Apr 4, 2025

Allows all prompts to take a custom output or input which defaults to process.stdout and process.stdin respectively.

Copy link

changeset-bot bot commented Apr 4, 2025

🦋 Changeset detected

Latest commit: 2539861

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@43081j 43081j requested a review from natemoo-re April 4, 2025 14:02
Copy link

pkg-pr-new bot commented Apr 4, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@268
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@268

commit: 2539861

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but you might need to resolve issues for approval.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is a great improvement!

Allows all prompts to take a custom `output` or `input` which defaults
to `process.stdout` and `process.stdin` respectively.
@43081j 43081j merged commit 7a556ad into main Apr 4, 2025
6 checks passed
@43081j 43081j deleted the common-opts branch April 4, 2025 21:52
@natemoo-re natemoo-re linked an issue Apr 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Pass custom stdin to prompts
3 participants