-
Notifications
You must be signed in to change notification settings - Fork 149
refactor(core + prompts): replace picocolors with styleText #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…or consistent styling across prompts
🦋 Changeset detectedLatest commit: 98c8c2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
|
looks good to me i left a raft of comments but they're all the same thing: you can use |
Co-authored-by: James Garbutt <[email protected]>
Thank you for reviewing it, and nice catch. I forgot about using array notation for nested styles. It looks way much cleaner. 🫣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
lets hold off merging until we (maintainers) catch up on the version constraint stuff but i think its good to go
Co-authored-by: James Garbutt <[email protected]>
Closes: #338