Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): update version to 1.0.2 #416

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 18, 2025

Update Bonita OpenAPI spec with 1.0.2 version.

  • Remove deleted API files (system/tenant)
  • Use Maintenance API to enable maintenance mode instead of pausing tenant
  • Remove unsupported runtime versions from tests

Covers BPM-418

⚠️ This breaks the compatibility with versions < 9.0 of Bonita runtime REST API (Mandatory to be able to support Bonita 10.3)

@abirembaut abirembaut marked this pull request as draft February 18, 2025 11:27
@github-actions github-actions bot force-pushed the feat/update-bonita-openapi-spec branch 2 times, most recently from 877440a to eb82377 Compare February 20, 2025 14:28
@github-actions github-actions bot force-pushed the feat/update-bonita-openapi-spec branch from 927e4cb to 8e25eae Compare February 20, 2025 15:49
@abirembaut abirembaut force-pushed the feat/update-bonita-openapi-spec branch 3 times, most recently from 74e994f to 2937e44 Compare February 20, 2025 16:31
@abirembaut abirembaut marked this pull request as ready for review February 20, 2025 16:31
@abirembaut abirembaut force-pushed the feat/update-bonita-openapi-spec branch from 173eb37 to a055f9d Compare February 20, 2025 17:22
@abirembaut abirembaut changed the title feat(openapi): update version feat(openapi): update version to 1.0.2 Feb 20, 2025
@tbouffard tbouffard self-requested a review February 21, 2025 08:51
Copy link
Contributor

@educhastenier educhastenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion and a few questions?

@@ -105,7 +105,7 @@ class BonitaClientIT {
private static final BonitaContainer<? extends BonitaContainer<?>> BONITA_CONTAINER = new BonitaContainer<>(
BONITA_DOCKER_IMAGE);

private static final Semver _10_2 = new Semver("10.2", SemverType.LOOSE);
private static final Semver _10_2 = new Semver("10.2.0", SemverType.LOOSE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set a "tolerance" mode when comparing versions, instead of setting the 3rd digit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is mandatory, otherwise the orEqual part of the comparison don't work (see vdurmont/semver4j#70)

* Remove deleted API files
* Use Maintenance API to enable maintenance mode instead of pausing tenant
* Remove unsupported runtime versions from tests
* Update version in README to 9.0
* Update test versions in github action
* fix version compare in IT test

Covers [BPM-418](https://bonitasoft.atlassian.net/browse/BPM-418)
@abirembaut abirembaut force-pushed the feat/update-bonita-openapi-spec branch from 0902940 to 18c94ca Compare February 21, 2025 15:12
@abirembaut abirembaut merged commit a5702f0 into develop Feb 21, 2025
11 checks passed
@abirembaut abirembaut deleted the feat/update-bonita-openapi-spec branch February 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants