-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi): update version to 1.0.2 #416
Conversation
877440a
to
eb82377
Compare
src/main/java/org/bonitasoft/web/client/api/AuthenticationApi.java
Outdated
Show resolved
Hide resolved
927e4cb
to
8e25eae
Compare
74e994f
to
2937e44
Compare
173eb37
to
a055f9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggestion and a few questions?
@@ -105,7 +105,7 @@ class BonitaClientIT { | |||
private static final BonitaContainer<? extends BonitaContainer<?>> BONITA_CONTAINER = new BonitaContainer<>( | |||
BONITA_DOCKER_IMAGE); | |||
|
|||
private static final Semver _10_2 = new Semver("10.2", SemverType.LOOSE); | |||
private static final Semver _10_2 = new Semver("10.2.0", SemverType.LOOSE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set a "tolerance" mode when comparing versions, instead of setting the 3rd digit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is mandatory, otherwise the orEqual part of the comparison don't work (see vdurmont/semver4j#70)
src/main/java/org/bonitasoft/web/client/services/impl/DefaultBdmService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/bonitasoft/web/client/services/impl/DefaultBdmService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/bonitasoft/web/client/feign/BonitaFeignClient.java
Outdated
Show resolved
Hide resolved
* Remove deleted API files * Use Maintenance API to enable maintenance mode instead of pausing tenant * Remove unsupported runtime versions from tests * Update version in README to 9.0 * Update test versions in github action * fix version compare in IT test Covers [BPM-418](https://bonitasoft.atlassian.net/browse/BPM-418)
0902940
to
18c94ca
Compare
|
Update Bonita OpenAPI spec with 1.0.2 version.
Covers BPM-418