HeaderMenu 수정 #150
Merged
HeaderMenu 수정 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiSoJeong
added
🐣 feature
domino8788
approved these changes
Dec 20, 2020
| if (content === '>') return BlockType.TOGGLE_LIST; | ||
| if (content === '|') return BlockType.QUOTE; | ||
| for (const [key, reg] of Object.entries(regexType)) { | ||
| if (validator(reg, content)) return key as BlockType; |
There was a problem hiding this comment.
깔끔하게 줄이셨네요. 굳굳 저도 참고하겠습니다.
| @@ -40,22 +39,18 @@ function Header({}: Props): JSX.Element { | |||
| const staticMenuToggle = useRecoilValue(staticMenuToggleState); | |||
| const selectedPage = useRecoilValue(pageState); | |||
|
|
|||
| const date = `Updated ${timeSince(new Date())} ago`; | |||
| const people = `${3}명 접속중`; | |||
There was a problem hiding this comment.
실시간 동기화 로직을 구현한 보람이 여기에 담기겠네요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderMenu 수정
해당 이슈 📎
#146
변경 사항 🛠
헤더 요소 변경
테스트 ✨
없음
리뷰어 참고 사항 🙋♀️