[Refactor] 도메인 모듈 리팩토링 #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 필요 없는 코드 삭제 - 놓치고 있던 부분 추가
# Conflicts: # Domain/Domain/Sources/Entity/DrawingObject.swift # Domain/Domain/Sources/Entity/WhiteboardObject.swift
ekrud99
approved these changes
Jan 10, 2025
Member
Author
|
동시성 문제에 대한 논의를 다함께 했기 때문에 머지 하겠습니다 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
도메인 모듈을 어느정도 리팩토링 진행하던 중,
동시성 문제를 해결할 수 있는 코드가 추가되어 먼저 PR을 올립니다.
👩💻 Contents
✅ Testing
테스트 목적과 상황
텍스트 오브젝트를 추가하는 상황
시나리오 진행에 필요한 값
시나리오 완료 시 보장하는 결과
정상적인 좌표를 갖고있는 텍스트 오브젝트를 반환
📝 Review Note