Skip to content

Conversation

@clxxrlove
Copy link
Member

@clxxrlove clxxrlove commented Dec 5, 2024

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ ๋ฒˆํ˜ธ


๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ํ…Œ์ŠคํŠธ
  • ๋ฆฌํŒฉํ† ๋ง

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ (๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ๋‚ด์—ญ์„ ๊ธฐ์žฌํ•ฉ๋‹ˆ๋‹ค.)

  • Domain Layer์˜ ๋ชจ๋“  ๊ฐ์ฒด์˜ ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€
  • ์–ด์ƒ‰ํ•œ ํŠน์ • ๊ฐ์ฒด์˜ ์ด๋ฆ„ ๋ณ€๊ฒฝ

@clxxrlove clxxrlove added the ๐Ÿ“ Test ํ…Œ์ŠคํŠธ label Dec 5, 2024
@clxxrlove clxxrlove self-assigned this Dec 5, 2024
@clxxrlove clxxrlove added the โ™ป๏ธ Refactor ๋ฆฌํŒฉํ† ๋ง label Dec 5, 2024
Copy link
Collaborator

@ParkSeongGeun ParkSeongGeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค :)

Copy link
Member

@Hansangjin98 Hansangjin98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MockRepository๋“ค์˜ ๊ตฌํ˜„์„ ๋ณด๋ฉด Call Count๋ฅผ ์ฒดํฌํ•˜๊ณ ์ž ์˜๋„ํ•œ ๊ฒƒ ๊ฐ™์€๋ฐ, ์‹ค์ œ ํ…Œ์ŠคํŠธ์—์„œ๋Š” ์ฒดํฌํ•˜๋Š” ๋ถ€๋ถ„์ด ์—†๋„ค์š”!
๋น ๋œจ๋ฆฌ์‹  ๊ฑธ๊นŒ์š”? ๋˜ํ•œ ๋‹จ์ˆœ Call Coutnt ์ฒดํฌ๋ฟ๋งŒ ์•„๋‹ˆ๋ผ ์‹ค์ œ ๋กœ์ง์˜ ํ…Œ์ŠคํŠธ๊ฐ€ ํ•„์š”ํ•  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Comment on lines +14 to +20
override func setUp() {
sut = EmotionPromptGenerator()
}

override func tearDown() {
sut = nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

override ํ•จ์ˆ˜๋ฅผ ์‚ฌ์šฉํ•˜๋Š”๋ฐ super์˜ ํ•จ์ˆ˜ ํ˜ธ์ถœ์ด ์—†๋„ค์š”.
ํ˜„์žฌ๋Š” ์•„๋ฌด๋Ÿฐ ๋ฌธ์ œ๊ฐ€ ์—†์„ ์ˆ˜ ์žˆ์ง€๋งŒ, ์ฝ”๋“œ์˜ ์ผ๊ด€์„ฑ๊ณผ ์œ ์ง€๋ณด์ˆ˜์„ฑ์„ ์œ„ํ•ด ๊ด€๋ก€์ ์œผ๋กœ๋ผ๋„ ํ˜ธ์ถœํ•˜๋Š” ๊ฒƒ์ด ์–ด๋–จ๊นŒ์š”?
๋‹ค๋ฅธ ํด๋ž˜์Šค๋“ค์—์„œ๋„ ๋ชจ๋‘ ๋งˆ์ฐฌ๊ฐ€์ง€์ž…๋‹ˆ๋‹ค.

override func setUp() {
    super.setUp()
    sut = EmotionPromptGenerator()
}

override func tearDown() {
    sut = nil
    super.tearDown()
}

Comment on lines +16 to +17
var plainText: String!
var hashed: String!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‘ ๊ฐ’์€ tearDown ์‹œ์ ์— ์ดˆ๊ธฐํ™”์‹œ์ผœ์ฃผ์ง€ ์•Š์•„๋„ ๊ดœ์ฐฎ์€๊ฐ€์š”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

โ™ป๏ธ Refactor ๋ฆฌํŒฉํ† ๋ง ๐Ÿ“ Test ํ…Œ์ŠคํŠธ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants