[Feat] 회원가입/로그인/로그아웃 API 구현 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@jjeonghak |
PMtHk
previously approved these changes
Nov 10, 2024
Collaborator
PMtHk
left a comment
PMtHk
left a comment
There was a problem hiding this comment.
수고하셨습니다.
뷰 작업도 힘을 좀 내야겠군요!
| import { Account } from '../entity/account.entity'; | ||
|
|
||
| @Injectable() | ||
| export class AccountService { |
Collaborator
There was a problem hiding this comment.
❓
AccountService 는 AccountRepository 의 Wrapper 클래스로 사용하신 건가요?
Collaborator
Author
There was a problem hiding this comment.
아직 Account에 별다른 정보와 기능이 없어서 지금은 래퍼 클래스라고 봐도 무방한 것 같습니다. authService랑 분리를 일단 해두었는데 이후에도 별다른 기능이 없다면 사실 통합해도 될 것 같이요
iam454
previously approved these changes
Nov 10, 2024
Collaborator
iam454
left a comment
iam454
left a comment
There was a problem hiding this comment.
빠..빠르다..!
(끄응 솔직히 nest 코드 잘 모르겠습니다.. ㅠㅠ)
yangchef1
reviewed
Nov 10, 2024
| throw new UnauthorizedException('Invalid refresh token'); | ||
| } | ||
| const accessToken = await this.generateAccessToken({ id: user.id, username: user.username }); | ||
| return { accessToken, refreshToken }; |
Member
There was a problem hiding this comment.
access 토큰 재발급 로직에서 refresh 토큰은 재발급 하지 않아도 괜찮을까요 ?
Collaborator
Author
There was a problem hiding this comment.
access 토큰은 재발급하고, refresh 토큰이 만료되면 다시 로그인해야하는 로직으로 구현했습니다
yangchef1
reviewed
Nov 10, 2024
Comment on lines
+65
to
+77
| private generateAccessToken(payload: { id: number; username: string }) { | ||
| return this.jwtService.signAsync(payload, { | ||
| secret: this.configService.get<string>('JWT_ACCESS_TOKEN_SECRET'), | ||
| expiresIn: this.configService.get<string>('JWT_ACCESS_TOKEN_TIME'), | ||
| }); | ||
| } | ||
|
|
||
| private generateRefreshToken(payload: { id: number; username: string }) { | ||
| return this.jwtService.signAsync(payload, { | ||
| secret: this.configService.get<string>('JWT_REFRESH_TOKEN_SECRET'), | ||
| expiresIn: this.configService.get<string>('JWT_REFRESH_TOKEN_TIME'), | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
토큰 생성 로직은 별도 클래스로 분리하는 것도 괜찮을 것 같아요 !
yangchef1
previously approved these changes
Nov 10, 2024
yangchef1
previously approved these changes
Nov 11, 2024
PMtHk
approved these changes
Nov 11, 2024
iam454
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
#26 #23 #30
작업 내용
고민과 학습내용
로그인 관련 작업을 일단 간단하게 구현해보았습니다.
Authoriaztion헤더와X-Refresh-Toekn헤더에 jwt 토큰을 이용해서 처리하는 방식입니다.