Add dual-sequence overloads to transform_inclusive_scan() and transform_exclusive_scan() #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - C++20 added `constexpr` to `transform_inclusive_scan()`. The existing implementations could be `constexpr` but were not updated. Solution: - Add `constexpr`.
Problem: - `transform()` has an overload that takes two input sequences - in other languages this is called `zip()`. - `transform_reduce()` has an overload that takes two input sequences. - `transform_inclusive_scan()` does not have this overload, despite its obvious utility from the other cases. Solution: - Implement an overload of `transform_inclusive_scan()` that takes two input sequences.
Problem: - C++20 added `constexpr` to `transform_exclusive_scan()`. The existing implementation could be `constexpr` but was not updated. Solution: - Add `constexpr`.
Problem: - `transform()` has an overload that takes two input sequences - in other languages this is called `zip()`. - `transform_reduce()` has an overload that takes two input sequences. - `transform_inclusive_scan()` has an overload that takes two input sequences. - `transform_exclusive_scan()` does not have this overload, despite its obvious utility from the other cases. Solution: - Implement an overload of `transform_exclusive_scan()` that takes two input ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are dual-sequence overloads for
transform()(this overload is calledzipin may other languages) andtransform_reduce(), in the standard, but there is no similar version fortransform_inclusive_scan()ortransform_exclusive_scan(). This patch-set also addsconstexprsupport to the existing overloads.h/t to @elbeno for suggesting implementing this.