Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing std::optional handling being redundant in Boost version > 1.80 #1721

Merged
merged 1 commit into from
Feb 27, 2024
+3 −0
Merged

Fixing std::optional handling being redundant in Boost version > 1.80 #1721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gtsam/base/std_optional_serialization.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

// Defined only if boost serialization is enabled
#ifdef GTSAM_ENABLE_BOOST_SERIALIZATION
// Only for old boost
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Only for old boost
// NOTE: Added in Boost 1.80
// See Boost CHANGELOG: https://www.boost.org/users/history/version_1_80_0.html

#if BOOST_VERSION < 108000
#pragma once
#include <optional>
#include <boost/config.hpp>
Expand Down Expand Up @@ -99,3 +101,4 @@ void serialize(Archive& ar, std::optional<T>& t, const unsigned int version) {
} // namespace serialization
} // namespace boost
#endif
#endif
Loading