-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Fixes and Updates #1723
Conversation
It not fair that you cancel my PR, but you use my changes. Be fair. |
@talregev your PR didn't clearly state what the issue you were trying to solve was. I encountered the issue myself this week and recalled your fix. |
Even you think I wasn't communicate enough, and then you recall my fix, Do you think is a reason to steal it like that? I will put my description here of my PR that the community will judge if it was communicate enough.
|
Sounds good. I'm re-reading your comment and it clearly doesn't mention what issue your PR is trying to fix. There is some vague mention of the MacOS VM but nothing about the fact that the latest boost version is causing a name collision with std::optional. I looked up the error and the suggested fix was similar to yours which is why I recalled your PR. There was no ill intention and I didn't have the time to reopen your PR and go through the review back and forth, hence why I added it to this PR. |
The fix on macOS doesn't seem to generalize to Ubuntu. I'll look into it later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sans one comment
save
,load
, etc withboost/serialization/optional.hpp
.BarometricFactor
as required in Custom Factor in MATLAB #1722.I ran this locally on my machine Matlab and it works great!