-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSVC toolset version #1768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. If it is relevant, it might be worth mentioning in the INSTALL.md:
Line 97 in a2a7a06
- Set the `Toolset` to `msvc_x64_x64`. If you know what toolset you require, then skip this step. |
but based on what I understand, this is just a CI thing and not an actual install requirement version change so no change is necessary.
Also, re: pybind upgrade, this also seems reasonable if you want to go for it. Will that be a separate PR or is it closely related enough to warrant combining in / replacing this PR?
Pybind update should be done with the script |
Yes I'll use the script but it first needs to be updated in the wrap project. Can you please take a look at the PR I made there? |
Made a temporary fix by restricting the numpy version to be below |
Based on the Windows image from the Github Actions images repo, the minimum toolset version for MSVC should be 14.40.
This PR updates our CI to follow this.