Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comparisons #1896

Merged
merged 8 commits into from
Nov 27, 2024
Merged

More comparisons #1896

merged 8 commits into from
Nov 27, 2024

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Nov 5, 2024

Added

  • Essential + K: uses new constructor to optimize for a single K
  • "Binary + Ks" and "Binary + K": use EssentialMatrixFactor: makes error much less as only pairwise errors checked
    It's clear that the binary EssentialMatrixFactors do much better in terms of geodesic distance, even without "enforcing consistency". They also optimize quite fast. Although: I have to admit I don't understand how they can do better than "Calibrated", which uses ground truth K. Maybe the transfer error pushes away from ground truth in an unexpected way.
image

@dellaert dellaert changed the title epipolarLine More comparisons Nov 6, 2024
Copy link
Contributor

@travisdriver travisdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, excited to try out in GTSfM :)

@dellaert dellaert merged commit 979fb93 into develop Nov 27, 2024
33 checks passed
@dellaert dellaert deleted the feature/moreComparisons branch January 10, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants