Using 'msg' and 'group_id' at the same time. Some /clear and /close fixes. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bostrot
requested changes
Mar 1, 2023
src/commands.ts
Outdated
| @@ -105,7 +108,7 @@ function closeCommand(ctx: Context) { | |||
| if (cache.config.categories) { | |||
| cache.config.categories.forEach((element: any, index: number) => { | |||
| // No subgroup | |||
| if (cache.config.categories[index].subgroups.length > 0) { | |||
| if (cache.config.categories[index].subgroups == undefined) { | |||
There was a problem hiding this comment.
length > 0 would mean if there is at least one subgroup while subgroups == undefined would mean there is no subgroup.
There was a problem hiding this comment.
That's right. However, if no subgroups are specified, an error occurs. If it has a length of 0, forEach will be ignored. cache.config.categories[index].subgroups == undefined || cache.config.categories[index].subgroups.length == 0 perhaps it would be more correct.
There was a problem hiding this comment.
Yes, please update it with cache.config.categories[index].subgroups == undefined && cache.config.categories[index].subgroups.length > 0 :)
|
Hashtags for categories related to the issue #125 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tickets from cache on /clear and /close. Otherwise, the user will not receive a notification about sending a message if the previous ticket was closed. It may also be related to the issue #121.
Allow to use 'msg' and 'group_id' at the same time. It is convenient if additional information is always needed to answer a question. Also, it looks like a solution for issue #99.