Only set default checksum if request_checksum_calculation config is set to when_supported
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
SamRemis
approved these changes
Jan 22, 2025
aws-sdk-python-automation
added a commit
that referenced
this pull request
Jan 23, 2025
* release-0.11.2: Bumping version to 0.11.2 Only set default checksum if ``request_checksum_calculation`` config is set to ``when_supported`` (#329)
hswong3i
pushed a commit
to alvistack/boto-s3transfer
that referenced
this pull request
Jan 24, 2025
…is set to ``when_supported`` (boto#329) * Only set default checksum if ``request_checksum_calculation`` config is set to ``when_supported`` * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #327
This PR checks the
request_checksum_calculationconfig on the S3 client before setting a default checksum for both non-MPU and MPU. Ifrequest_checksum_calculationis set towhen_supported, the default checksum from botocore (currentlyCRC32) is applied. Ifrequest_checksum_calculationis set towhen_required, no default checksum is applied.