kubernetes: fix fail-cgroup-v1 serialization #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsssun
force-pushed
the
fail-cgroup-v1-setting/settings-sdk
branch
4 times, most recently
from
af872d2 to
f2aa7a7
Compare
Add skip_serializing_if to prevent null serialization when None. Signed-off-by: Yutong Sun <[email protected]>
Signed-off-by: Yutong Sun <[email protected]>
ytsssun
force-pushed
the
fail-cgroup-v1-setting/settings-sdk
branch
from
f2aa7a7 to
f0d63ea
Compare
Contributor
Author
|
Closing this PRas it was created based off a wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
bottlerocket-os/bottlerocket#4725
Description of changes:
Fix serialization of fail-cgroup-v1 setting added in #108.
The field was missing
skip_serializing_if = "Option::is_none"which caused it to serialize as null instead of being omitted when not set. This broke thetest_default_kubernetes_settings_emptytest in core-kit that rely on default settings serializing to an empty object.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.