Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ObjectUnsubscribedError on prevSubject and nextSubject unsubscr… #3

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

msamprz
Copy link
Contributor

@msamprz msamprz commented Feb 15, 2018

Fixes ObjectUnsubscribedError on prevSubject and nextSubject unsubscribing

This issue arose on:

Angular CLI: 1.6.1
Node: 8.5.0
OS: win32 x64
Angular: 5.2.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cdk: 5.2.0
@angular/cli: 1.6.1
@angular/material: 5.2.0
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.1
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.6.2
webpack: 3.10.0

@msarsha msarsha mentioned this pull request Feb 16, 2018
@bougarfaoui bougarfaoui merged commit 3f16130 into bougarfaoui:master Feb 16, 2018
@bougarfaoui
Copy link
Owner

@msamprz Thanks for the PR :)

@msamprz
Copy link
Contributor Author

msamprz commented Feb 16, 2018

@bougarfaoui Thanks for the module, my dude :)

@sagarguhe
Copy link

I am not getting this change in my install.. what to do?

@msamprz
Copy link
Contributor Author

msamprz commented May 21, 2018

@sagarguhe I believe @bougarfaoui hasn't pushed this code to npm. I found this out later in another issue in this repo. The solution is to use a different package, from a fork of this fix. I would have done it myself but I thought @bougarfaoui would push it to npm. Below you can find the package.

https://www.npmjs.com/package/ng-carousel-iuno
https://github.com/goergch/ui-carousel

npm i ng-carousel-iuno

@sagarguhe
Copy link

@msamprz thanks for the solution! I have installed your forked package using npm i ng-carousel-iuno --save it is installed correctly but when I try to import UICarouselModule from ng-carousel-iuno ng-serve throws this error: ERROR in src/app/components/service-view/service-view.module.ts(7,34): error TS2307: Cannot find module 'ng-carousel- iuno'

@sagarguhe
Copy link

sagarguhe commented May 21, 2018

@msamprz never mind I installed the package again and it fixed the issue.. :) thanks for the fix 💯

@msamprz
Copy link
Contributor Author

msamprz commented May 21, 2018

@sagarguhe no problem. Good luck!

@Muthukumaruma
Copy link

I updated the package but still I am facing the same issue

@msamprz
Copy link
Contributor Author

msamprz commented Jun 27, 2018

Is your package the fork?

@Muthukumaruma
Copy link

hope no, I installed through npm

@msamprz
Copy link
Contributor Author

msamprz commented Jun 27, 2018

From what I know and remember, this PR merge was not pushed to npm, so the fix is not implemented into the npm package. Try npm i ng-carousel-iuno this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants