Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Episode and Disk Management with Additional Features and Optimizations #489

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

brand-it
Copy link
Owner

@brand-it brand-it commented Oct 31, 2024

Major Updates

  • movie_title_table_component.html.erb and search_component.html.erb
    • Updated templates for better structure and maintainability.
  • SearchComponent
    • Added submit_on_key_up option for more customizable behavior.
    • Refactored methods (form_data, input_html) for better reusability and readability.
  • SeasonsController
    • Improved rip action with memoized helper methods (season, disk, tv) for cleaner and more efficient code.
  • DiskTitle, Episode, and VideoBlob Models
    • Added episode_last and part attributes.
    • Included set_episode_last and set_part methods for consistency in data handling.
  • New Service: EpisodeDiskTitleSelectorService
    • Created a service for handling episode and disk title selection logic to improve clarity and separation of concerns.
  • Enhancements to Existing Services
    • CreateMkvService: Added support for the part attribute for multipart episodes.
    • Ftp::VideoScannerService and KeyParserService: Enhanced to parse and handle part attributes during video blob creation.
  • View Enhancements
    • movies/show.html.erb: Adjusted instantiation of the SearchComponent.
    • seasons/show.html.erb: Enhanced episode details layout and added a form for dynamic episode selection.
    • tvs/show.html.erb: Updated SearchComponent instantiation for consistency.
  • RipWorker
    • Expanded schema to include an optional part attribute to support advanced processing needs.
  • ScanPlexWorker
    • Added job progress messaging and refactored for better performance and clarity.

Miscellaneous

  • Standardized variable naming and method structures.
  • Improved data-handling to manage empty relationships and updated associations more efficiently.

@brand-it brand-it force-pushed the general-improvements-and-better-support-for-tv-shows branch 2 times, most recently from 0481c9f to 116abf8 Compare October 31, 2024 17:55
@brand-it brand-it force-pushed the general-improvements-and-better-support-for-tv-shows branch from 116abf8 to a53fbdf Compare October 31, 2024 17:56
@brand-it brand-it changed the title Added TV show improvements to support episode parts and ranges Enhance Episode and Disk Management with Additional Features and Optimizations Oct 31, 2024
@brand-it brand-it marked this pull request as ready for review October 31, 2024 18:06
@brand-it brand-it merged commit a2546b1 into main Oct 31, 2024
2 checks passed
@brand-it brand-it deleted the general-improvements-and-better-support-for-tv-shows branch October 31, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant