feat: toggle tos version based on environments (#2750)

services/rewards/cmd/rest_run.go

@@ -72,13 +72,16 @@ func RestRun(command *cobra.Command, args []string) {
 		ctx = context.WithValue(ctx, appctx.DefaultACChoicesCTXKey, acChoices)
 	}
 
+	env := os.Getenv("ENV")
+	if env == "" {
+		lg.Fatal().Err(err).Msg("error retrieving environment")
+	}
+
 	tosVersion, err := strconv.Atoi(os.Getenv("REWARDS_TOS_VERSION"))
 	if err != nil {
 		lg.Fatal().Err(err).Msg("error retrieving rewards terms of service version")
 	}
 
-	tosEnabled, _ := strconv.ParseBool(os.Getenv("REWARDS_TOS_VERSION_ENABLED"))
-
 	// Get the bucket from the context and not os.Getenv so we don't diverge. GetParameters uses the context on
 	// each request and this will need to be refactored before we can remove it.
 	cardsBucket, ok := ctx.Value(appctx.ParametersMergeBucketCTXKey).(string)
@@ -92,8 +95,8 @@ func RestRun(command *cobra.Command, args []string) {
 	}
 
 	cfg := &rewards.Config{
+		Env:        env,
 		TOSVersion: tosVersion,
-		TOSEnabled: tosEnabled,
 		Cards: &rewards.CardsConfig{
 			Bucket: cardsBucket,
 			Key:    cardsKey,

services/rewards/service.go

@@ -33,8 +33,8 @@ type CardsConfig struct {
 }
 
 type Config struct {
+	Env        string
 	TOSVersion int
-	TOSEnabled bool
 	Cards      *CardsConfig
 }
 
@@ -49,6 +49,22 @@ type Service struct {
 	s3Svc                s3Service
 }
 
+func (c *Config) isDevelopment() bool {
+	if c == nil {
+		return false
+	}
+
+	return c.Env == "development"
+}
+
+func (c *Config) isStaging() bool {
+	if c == nil {
+		return false
+	}
+
+	return c.Env == "staging"
+}
+
 func (s *Service) Jobs() []srv.Job {
 	return s.jobs
 }
@@ -159,7 +175,7 @@ func (s *Service) GetParameters(ctx context.Context, currency *BaseCurrency) (*P
 		},
 	}
 
-	if s.cfg.TOSEnabled {
+	if s.cfg.isDevelopment() || s.cfg.isStaging() {
 		params.TOSVersion = s.cfg.TOSVersion
 	}
 

services/rewards/service_test.go

@@ -101,3 +101,107 @@ func (m *mockS3Service) GetObject(ctx context.Context, params *s3.GetObjectInput
 
 	return m.fnGetObject(ctx, params, optFns...)
 }
+
+func TestConfig_isDevelopment(t *testing.T) {
+	type tcGiven struct {
+		c *Config
+	}
+
+	type tcExpected struct {
+		val bool
+	}
+
+	type testCase struct {
+		name  string
+		given tcGiven
+		exp   tcExpected
+	}
+
+	tests := []testCase{
+		{
+			name: "empty",
+		},
+
+		{
+			name: "false",
+			given: tcGiven{
+				c: &Config{
+					Env: "env",
+				},
+			},
+		},
+
+		{
+			name: "true",
+			given: tcGiven{
+				c: &Config{
+					Env: "development",
+				},
+			},
+			exp: tcExpected{
+				val: true,
+			},
+		},
+	}
+
+	for i := range tests {
+		tc := tests[i]
+
+		t.Run(tc.name, func(t *testing.T) {
+			actual := tc.given.c.isDevelopment()
+			assert.Equal(t, tc.exp.val, actual)
+		})
+	}
+}
+
+func TestConfig_isStaging(t *testing.T) {
+	type tcGiven struct {
+		c *Config
+	}
+
+	type tcExpected struct {
+		val bool
+	}
+
+	type testCase struct {
+		name  string
+		given tcGiven
+		exp   tcExpected
+	}
+
+	tests := []testCase{
+		{
+			name: "empty",
+		},
+
+		{
+			name: "false",
+			given: tcGiven{
+				c: &Config{
+					Env: "env",
+				},
+			},
+		},
+
+		{
+			name: "true",
+			given: tcGiven{
+				c: &Config{
+					Env: "staging",
+				},
+			},
+			exp: tcExpected{
+				val: true,
+			},
+		},
+	}
+
+	for i := range tests {
+		tc := tests[i]
+
+		t.Run(tc.name, func(t *testing.T) {
+			actual := tc.given.c.isStaging()
+			assert.Equal(t, tc.exp.val, actual)
+		})
+	}
+}