Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 134.0.6998.15 to Chromium 134.0.6998.24 #44111

Closed
cdesouza-chromium opened this issue Feb 20, 2025 · 6 comments · Fixed by brave/brave-core#27737
Closed

Comments

@cdesouza-chromium
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/134.0.6998.15..134.0.6998.24?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@cdesouza-chromium cdesouza-chromium added Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/Test-Plan-Specified QA/Yes release-notes/include labels Feb 20, 2025
@emerick emerick changed the title Upgrade from Chromium **134.0.6998.15** to Chromium **134.0.6998.24** Upgrade from Chromium 134.0.6998.15 to Chromium 134.0.6998.24 Feb 20, 2025
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 20, 2025
@kjozwiak
Copy link
Member

The above requires 1.76.66 or higher for 1.76.x verification 👍 Basically needs a build with C134.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 24, 2025

Quick overview of the work remaining re: affected areas due to C134 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #43213 (comment):

Platforms that still need to check/verify the affected areas due to C134 changes as per #43213 (comment):

  • macOS - Affected Areas still needs to be checked/verified
  • Linux - Affected Areas still needs to be checked/verified
  • Android Tablet - Affected Areas still needs to be checked/verified

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 24, 2025

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.77.58 Chromium: 134.0.6998.24 (Official Build) canary (64-bit) 
Revision	9650f9120c4d60d56e99edeac281df2cc47faed7
OS	Android 13; Build/TP1A.220624.014; 33; REL
example example
Image Image

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.76.67 Chromium: 134.0.6998.24 (Official Build) beta (64-bit)
-- | --
Revision | 37df3410fb57f74420f170361ec1d834c6953a75
OS | Windows 10 Version 22H2 (Build 19045.5487)

Image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 25, 2025
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 25, 2025

Verification COMPLETED on macOS 12.5 arm64 using the following build(s):

Brave | 1.76.67 Chromium: 134.0.6998.24 (Official Build) beta (arm64)
-- | --
Revision | 37df3410fb57f74420f170361ec1d834c6953a75
OS | macOS Version 12.5 (Build 21G72)
Tab-related functionality (tab grouping, dragging tabs, tab search, vertical tabs, etc.)_PASSED

Tab search:

  • Confirmed that all the opened/closed tabs are opened via Tab search panel
  • Confirmed that user can see recently closed tabs via Tab search panel
  • Confirmed that user can search specific site via Tab search panel
  • Confirmed that user can close the specific tab via Tab search panel

Vertical tabs:

  1. Pin and unpin tab
  2. Drag and drop a tab on tab bar
  3. Create a tab group
  4. Add a new/existing tab to new/existing tab group
  5. Tearing tab from tab bar and tab group
  6. Tab hover affect

Horizonal Tabs:

  1. Pin and unpin tab
  2. Drag and drop a tab on tab bar
  3. Create a tab group
  4. Add a new/existing tab to new/existing tab group
  5. Tearing tab from tab bar and tab group
  6. Tab hover affect
Search engine selection/default search_PASSED
Case 1: New user from Brave Search default SE target country (India)_PASSED
  1. Clean profile 1.77.x
  2. Check Brave is the default SE via brave://settings/search for both Normal and Private windows
  3. Check that Change button is shown next to default SE for Normal window search settings
  4. Click on Change button and ensured that list of SE's displayed in the dropdown
  5. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
  6. Check search suggestions option is enabled by default in brave://settings/search
  7. Confirmed brave search suggestions are shown when typing into the omnibox
Case 2: Existing user from Brave Search default SE target country (India)_default search settings not modified prior upgrade_PASSED
  1. Clean profile 1.75.x
  2. Check Brave is the default SE via brave://settings/search
  3. Check search suggestions option is enabled by default in brave://settings/search
  4. Upgrade the profile to 1.76.x
  5. Check that Change button is shown next to default SE for Normal window search settings
  6. Click on Change button and ensured that list of SE's displayed in the dropdown
  7. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
  8. Confirm brave search suggestions are shown when typing into the omnibox
Case 3: Existing user from Brave Search default SE target country (India)_default search settings modified prior upgrade_PASSED
  1. Clean profile 1.75.x
  2. Check Brave is the default SE via brave://settings/search
  3. Check search suggestions option is enabled by default in brave://settings/search
  4. Change the default SE to Bing or any SE other than Brave in both Normal and PT
  5. Upgrade the profile to 1.76x
  6. Check that Bing is the default SE in both Normal and PT windows and Change button is shown next to default SE for Normal window
  7. Click on Change button and ensured that list of SE's displayed in the dropdown
  8. Confirmed that Brave is first SE in the dropdown
  9. Confirm Bing search suggestions are shown when typing into the omnibox
  10. Change the Search engine to Google and click on Set as default
  11. Confirmed default SE is set to Google in Normal windows
  12. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner
Creating/using a new profile_PASSED
  • Confirmed that user can create a new profile by using Add new profile menu option via hamburger menu
  • Confirmed that user can switch to different profile via profile picker menu
  • Confirmed that user can ADD/Edit/Delete the profiles via Profile manager
  • Confirmed that user can open the Guest window using Open Guest profile option via profile picker
  • Open few sites and update the brave://settings in Profile 1 and ensure that the change made in profile 1 aren't reflected in other profiles
Example Example Example Example
Image Image Image Image
Bookmarks bar_PASSED
  • Confirmed that bookmarks are shown on the bookmarks bar when show bookmarks always option is selected
  • Confirmed that bookmarks bar is shown on the NTP
  • Confirmed that bookmarks cab be drag and dropped on the bookmarks bar
  • Confirmed that bookmarks bar is shown on the Private and Private window with Tor tabs
  • Confirmed that tab groups are shown on the bookmarks bar by default
Side panel_PASSED

Bookmarks

  • Confirmed that imported bookmarks are listed under Bookmarks tab under the side panel
  • Confirmed that bookmarks can be sorted from A-Z and Z-A
  • Confirmed that bookmarks can be added/deleted
  • Confirmed that bookmarks folders can be added via Bookmarks side panel option
  • Confirmed that bookmarks can be viewed in compact/visual view

Reading list

  • Confirmed that user can add open tab/sites to the reading list using Add tab to the reading list option
  • Confirmed that tabs added to the reading list are shown under reading list sidebar panel
  • Confirmed that user can add the current tab to the reading list by clicking on Add current tab option via reading list sidebar panel
  • Confirmed that user delete the added sites from reading list by clicking on the x or close button
  • Confirmed that user can expand/collapse the reading list sites
  • Confirmed that user can segregate the reading list tabs/site to read/unread

Leo AI, Brave Talk, wallet and playlist:

  • Confirmed that click on Leo AI via sidebar panel opens up the Leo chat window, and user can ask questions via Leo AI and answers are given by Leo AI as expected
  • Confirmed that click on wallet via sidebar panel opens up the create brave wallet page as expected
  • Confirmed that click on Brave talk via sidebar panel open up the Brave talk join meeting page
  • Confirmed that click on Playlist via sidebar panel opens up the playlist panel and confirmed that user can add any video to the playlist
Split view functionality_PASSED

Split view complete testing will be taken care in the issue #36986 (comment)


Settings comparison

  • A new settings Card benefits added as part of CR134 via brave://settings/payments
Image - brave://settings headers are re-arranged and Brave Rewards is renamed to Rewards as part of Brave Image

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 25, 2025
@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favour of #44246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants