Upgrade from Chromium 134.0.6998.24 to Chromium 134.0.6998.39

[cdesouza-chromium]

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/134.0.6998.24..134.0.6998.39?pretty=fuller&n=10000

QA tests

• Check branding items
• Check for version bump

Minor Chromium bump

• No specific code changes in Brave (only line number changes in patches)

[kjozwiak]

Quick overview of the work remaining re: affected areas due to C134 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #43213 (comment):

• Windows - Requires quick spot check, full check completed via Upgrade from Chromium 133 to Chromium 134 #43213 (comment).

• Android ARM - Requires quick spot check, full check completed via Upgrade from Chromium 133 to Chromium 134 #43213 (comment).

• iOS - Requires quick spot check as there's nothing that needs to be checked on iOS as per Upgrade from Chromium 133 to Chromium 134 #43213 (comment).

• Android Tablet - Requires quick spot check, full check completed via Upgrade from Chromium 134.0.6998.15 to Chromium 134.0.6998.24 #44111 (comment).

• macOS - Requires quick spot check, full check completed via Upgrade from Chromium 134.0.6998.15 to Chromium 134.0.6998.24 #44111 (comment)

Platforms that still need to check/verify the affected areas due to C134 changes as per #43213 (comment):

• Linux - Affected Areas still needs to be checked/verified

[LaurenWags]

Verified with

Brave | 1.76.70 Chromium: 134.0.6998.39 (Official Build) (x86_64)
-- | --
Revision | aeb431fb107b09e67f4f55525d715afa28620f12
OS | macOS Version 14.7.4 (Build 23H420)

[kjozwiak]

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.76.70 Chromium: 134.0.6998.39 (Official Build) (64-bit)
--- | ---
Revision | aeb431fb107b09e67f4f55525d715afa28620f12
OS | Android 15; Build/AP4A.250205.002; 35; REL

---

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 14 using the following build(s):

Brave | 1.76.70 Chromium: 134.0.6998.39 (Official Build) (64-bit)
--- | ---
Revision | aeb431fb107b09e67f4f55525d715afa28620f12
OS | Android 14; Build/UP1A.231005.007; 34; REL

[btlechowski]

Verified with

1.76.70 Chromium	134.0.6998.39 (Official Build) (64-bit)
Revision	aeb431fb107b09e67f4f55525d715afa28620f12
OS	Linux

Tab-related functionality (tab grouping, dragging tabs, tab search, vertical tabs, etc.)_PASSED

Tab search:

• Confirmed that all the opened/closed tabs are opened via Tab search panel
• Confirmed that user can see recently closed tabs via Tab search panel
• Confirmed that user can search specific site via Tab search panel
• Confirmed that user can close the specific tab via Tab search panel

Vertical tabs:

1. Pin and unpin tab
2. Drag and drop a tab on tab bar
3. Create a tab group
4. Add a new/existing tab to new/existing tab group
5. Tearing tab from tab bar and tab group
6. Tab hover affect

Horizonal Tabs:

1. Pin and unpin tab
2. Drag and drop a tab on tab bar
3. Create a tab group
4. Add a new/existing tab to new/existing tab group
5. Tearing tab from tab bar and tab group
6. Tab hover affect

Search engine selection/default search_PASSED

Case 1: New user from Brave Search default SE target country (US)_PASSED

1. Clean profile 1.77.x
2. Check Brave is the default SE via brave://settings/search for both Normal and Private windows
3. Check that Change button is shown next to default SE for Normal window search settings
4. Click on Change button and ensured that list of SE's displayed in the dropdown
5. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
6. Check search suggestions option is enabled by default in brave://settings/search
7. Confirmed brave search suggestions are shown when typing into the omnibox

Case 2: Existing user from Brave Search default SE target country (US)_default search settings not modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Check Brave is the default SE via brave://settings/search
3. Check search suggestions option is enabled by default in brave://settings/search
4. Upgrade the profile to 1.77.x
5. Check that Change button is shown next to default SE for Normal window search settings
6. Click on Change button and ensured that list of SE's displayed in the dropdown
7. Confirmed that Google radio button is selected and is in the first place in the search engine dropdown
8. Confirm brave search suggestions are shown when typing into the omnibox

Case 3: Existing user from Brave Search default SE target country (US)_default search settings modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Check Brave is the default SE via brave://settings/search
3. Check search suggestions option is enabled by default in brave://settings/search
4. Change the default SE to Bing or any SE other than Brave in both Normal and PT
5. Upgrade the profile to 1.77.x
6. Check that Bing is the default SE in both Normal and PT windows and Change button is shown next to default SE for Normal window
7. Click on Change button and ensured that list of SE's displayed in the dropdown
8. Confirmed that Brave is first SE in the dropdown
9. Confirm Bing search suggestions are shown when typing into the omnibox
10. Change the Search engine to Google and click on Set as default
11. Confirmed default SE is set to Google in Normal windows
12. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner

Case 4: New user from outside brave search target country (Poland)_PASSED

1. Clean profile 1.77.x
2. Open brave://settings/search and ensured that Google is the default SE
3. Confirmed that Change button is shown next to default SE for Normal window SE settings
4. Click on Change button and ensured that list of SE's displayed in the dropdown
5. Confirmed that Google SE radio button is selected
6. Confirmed that Brave is first SE in the dropdown
7. Confirmed that Show search suggestion settings is disabled as expected
8. Confirm Google search suggestions are shown when typing into the omnibox

Case 5: New user from outside brave search target country (PL)_default search settings not modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Open brave://settings/search and ensured that Google is the default SE
3. Upgrade the profile to 1.77.x
4. Open brave://settings/search and ensured that Google is the default SE
5. Confirmed that Change button is shown next to default SE for Normal window SE settings
6. Click on Change button and ensured that list of SE's displayed in the dropdown
7. Confirmed that Google SE radio button is selected
8. Confirmed that Brave is first SE in the dropdown
9. Confirmed that Show search suggestion settings is disabled as expected
10. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner

Case 6: Existing user from outside brave search target country (Cuba)_default search settings modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Open brave://settings/search and ensured that Google is the default SE
3. Change the default SE to any SE other than Google (I have changed SE to StartPage)
4. Upgrade the profile to 1.77.x
5. Open brave://settings/search and ensured that StartPage is the default SE
6. Confirmed that Change button is shown next to default SE for Normal window SE settings
7. Click on Change button and ensured that list of SE's displayed in the dropdown
8. Confirmed that StartPage SE radio button is selected
9. Confirmed that Brave is first SE in the dropdown
10. Confirmed that Show search suggestion settings is disabled as expected
11. Confirm StartPage search suggestions are shown when typing into the omnibox along with Brave search promo banner

Creating/using a new profile_PASSED

• Confirmed that user can create a new profile by using Add new profile menu option via hamburger menu
• Confirmed that user can switch to different profile via profile picker menu
• Confirmed that user can ADD/Edit/Delete the profiles via Profile manager
• Confirmed that user can open the Guest window using Open Guest profile option via profile picker
• Open few sites and update the brave://settings in Profile 1 and ensure that the change made in profile 1 aren't reflected in other profiles

Bookmarks bar_PASSED

• Confirmed that bookmarks are shown on the bookmarks bar when show bookmarks always option is selected
• Confirmed that bookmarks bar is shown on the NTP
• Confirmed that bookmarks cab be drag and dropped on the bookmarks bar
• Confirmed that bookmarks bar is shown on the Private and Private window with Tor tabs
• Confirmed that tab groups are shown on the bookmarks bar by default

Side panel_PASSED

Bookmarks

• Confirmed that imported bookmarks are listed under Bookmarks tab under the side panel
• Confirmed that bookmarks can be sorted from A-Z and Z-A
• Confirmed that bookmarks can be added/deleted
• Confirmed that bookmarks folders can be added via Bookmarks side panel option
• Confirmed that bookmarks can be viewed in compact/visual view

Reading list

• Confirmed that user can add open tab/sites to the reading list using Add tab to the reading list option
• Confirmed that tabs added to the reading list are shown under reading list sidebar panel
• Confirmed that user can add the current tab to the reading list by clicking on Add current tab option via reading list sidebar panel
• Confirmed that user delete the added sites from reading list by clicking on the x or close button
• Confirmed that user can expand/collapse the reading list sites
• Confirmed that user can segregate the reading list tabs/site to read/unread

Leo AI, Brave Talk, wallet and playlist:

• Confirmed that click on Leo AI via sidebar panel opens up the Leo chat window, and user can ask questions via Leo AI and answers are given by Leo AI as expected
• Confirmed that click on wallet via sidebar panel opens up the create brave wallet page as expected
• Confirmed that click on Brave talk via sidebar panel open up the Brave talk join meeting page
• Confirmed that click on Playlist via sidebar panel opens up the playlist panel and confirmed that user can add any video to the playlist

---

Verified with

Brave	1.76.69 Chromium: 134.0.6998.24 (Official Build) beta (64-bit)
Revision	55ecc732897c3be718a5d828607782d3c54a2271
OS	Linux

Split view functionality_PASSED

• Verified the test plan from Use proper bounding box for positioning SidebarShowOptionsEventDetectWidget brave-core#27553

Creating a Split View

1. Right click on a tab and check that New Split View is below Reload in the menu. Select New Split View. The selected tab should appear on the left and a new tab page should appear on the right. Focus should appear on the newly created split item. In the tab bar, the items in the split view should come together and look combined and the split in focus should be highlighted.

2. Open a web page of your choice that has a few links and right click on a link. Check that Open Link in Split View is below Open Link in Private Window with Tor. Select Open Link in Split View and the linked page should appear to the right of the existing page. Focus should appear on the newly created split item.

3. Select two tabs, and select Open in Split View. Ensure that both tabs are opened in split view of equal size within the window and the right side split is in focus.

4. Select two tabs like above but in three more variations, 1. Pinned tab and a normal tab. 2. Tabs within a group. 3. Tabs that are not adjacent to each other.

5. Repeat above steps in Vertical tab mode.

Unsplit Tabs

1. Right click on a split view tab and select Unsplit Tabs. Tabs should be unsplit and look like before and will be next to each other.
2. Have a split view open, and select the the Split view button in the middle of the split and select Unsplit Tabs. Tabs should be unsplit and look like before.

Closing a tab in split view

1. Closing a tab in split view should act like normal and close the tab, either by selecting the x or by shortcut. By closing a tab within a split view automatically unsplits the tab and the other tab should remain. Restoring that tab should only restore the tab and not the split.

Drag and Dropping a Split View

1. Have several tabs open and also have a split view. Select the split view tabs and drag and drop to different positions within a full tab bar.
2. From step 2 above, check that you can drag a split view into a tab group.
3. Select split view tabs and drag the split view out to create a new window with just the split view. Drag the split view items from the new window and ensure you can drag back into the original window or any other open window.

Known/expected:

1. When 2 split view tabs are adjacent, drag and drop 1st split view will drag 2nd split tab view as well 

2. When a split view tab is dragged to a new window, along with split view the tab that is present next to the split view will also be dragged to a new window 

3. Can we drag a new/existing tab in-between the split view tab? the split focus is highlighted for three tabs - This is expected https://bravesoftware.slack.com/archives/CKNHM4RTK/p1740141337822829?thread_ts=1739912894.037299&cid=CKNHM4RTK

4. When there are two split views on a tab bar (not adjacent, there few tabs in-between the two split views) add/remove a split view into a tab group will add/remove both split views - Is this expected?

Pinning/unpinning a Split View

1. Pin a split view by selecting the split view tab and right clicking to Pin. Ensure that Pinned split view shows focus when selecting one of the split view items.
2. Ensure you can Unpin a split view by right clicking either Pinned split view item.

Resizing and Swapping Tab Positions

1. Right click on split tab and select Swap Tab Positions. Tab position should switch.
2. Select split view button in the middle of the screen and select Swap Tab Positions. Tabs positions should switch.
3. Hover over the separator (in the middle of the split) and the mouse pointer should turn into a resize pointer. Resize the window left and right and there should be a minimum width of the smaller window.

Appearance and security UI

1. When in a split view, check that the focused tab has a border around it and that the split tab in the tab bar is highlighted and also in focus.
2. Check that the unfocused tab shows the url of the page on the top left of the split view.
3. Select the tune/permissions button in the url bar and check that domain is the same as the focused tab.
4. Select the Shields button and check that domain is the same as the focused tab.

• Provided a suggestion on split view on dark mode via https://bravesoftware.slack.com/archives/CKNHM4RTK/p1740151592633749?thread_ts=1739912894.037299&cid=CKNHM4RTK
• Focus tab doesn't have border on a split view in an vertical tab orientation - Looks like known issue @rebron mentioned in the walkthrough