Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from Chromium 134.0.6998.24 to Chromium 134.0.6998.39 #27821

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Update from Chromium 134.0.6998.24 to Chromium 134.0.6998.39 #27821

merged 5 commits into from
Feb 27, 2025

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Feb 26, 2025 •
edited by emerick
Loading

Resolves brave/brave-browser#44246

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium requested review from a team as code owners February 26, 2025 15:09
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Feb 26, 2025
@emerick emerick added this to the 1.77.x - Nightly milestone Feb 26, 2025
@emerick emerick requested a review from a team February 26, 2025 15:13
@emerick emerick added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Feb 26, 2025
cdesouza-chromium and others added 5 commits February 26, 2025 19:48
@cdesouza-chromium
Update from Chromium 134.0.6998.24 to Chromium 134.0.6998.39.
3facba8
@cdesouza-chromium
Update patches from Chromium 134.0.6998.24 to Chromium 134.0.6998.39.
e7ed3ee
@cdesouza-chromium
Updated strings for Chromium 134.0.6998.39.
435c879
@samartnik @cdesouza-chromium
[Android] Remove base chrome layout
4176d40 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/76fac7530c580e7183de4aa7ecd34b837e38fb17

Fix incorrect anchor placement for Omnibox Suggestions Dropdown

The placement of the Anchor view for the Omnibox Suggestions Dropdown
was being computed based on a view with a different on-screen origin
(different (0,0) coordinates) than the view hosting the dropdown.
This mismatch caused visible gaps in multiple scenarios.

This change ensures that the parent view, which hosts both the Omnibox
Suggestions Dropdown and the anchor view, is used for positioning.
This approach eliminates the current issue and prevents similar
alignment problems in the future.

The change directly fixes the problem with Edge To Edge Everywhere.
@samartnik @cdesouza-chromium
[Android] Fixes for bytecode tests
94273f6
kjozwiak
kjozwiak approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kjozwiak kjozwiak merged commit 0026c9f into master Feb 27, 2025
18 checks passed
@kjozwiak kjozwiak deleted the cr134.0.6998.x branch February 27, 2025 00:42
@brave-builds
Copy link
Collaborator

Released in v1.78.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cdesouza-chromium cdesouza-chromium

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.78.x - Nightly
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 134.0.6998.24 to Chromium 134.0.6998.39
5 participants
@cdesouza-chromium @brave-builds @kjozwiak @emerick @samartnik