Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Translate Onboarding Issues #44272

Closed
3 of 5 tasks
Brandon-T opened this issue Feb 26, 2025 · 1 comment · Fixed by brave/brave-core#27836
Closed
3 of 5 tasks

[iOS] - Translate Onboarding Issues #44272

Brandon-T opened this issue Feb 26, 2025 · 1 comment · Fixed by brave/brave-core#27836
Assignees
Labels
feature/translate OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude

Comments

@Brandon-T
Copy link

Description

  • Translate can sometimes crash if you tap on the icon where the onboarding shows
  • Translate can show at the wrong time on a disabled translation page

Steps to reproduce

  1. Fresh Install
  2. Open a brand new tab
  3. Tap on the URL Bar
  4. Type: Wiki
  5. Tap on "Google" icon in the quick-search to search with the Google search engine

  1. Fresh Install
  2. Open a brand new tab
  3. Tap on Wikipedia
  4. Tap on Russian, Japanese, Spanish or other language that is NOT the same as the system language
  5. Translate Onboarding Popup shows
  6. Tap on the highlighted icon in the URL-Bar

Actual result

  • Translate Onboarding shows up
  • Translate Onboarding icon tap causes a crash

Expected result

  • Translate Onboarding should not show up on the Google page
  • Translate Onboarding icon tap should not cause a crash

Reproduces how often

Easily reproduced

Brave version

1.76.x

Device/iOS version

  • Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2025

The above requires 1.76.71 or higher for 1.76.x verification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/translate OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants