Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Fix Translation Onboarding on Disabled Pages (uplift to 1.76.x) #27869

Merged
merged 1 commit into from
Mar 1, 2025
Merged

[iOS] - Fix Translation Onboarding on Disabled Pages (uplift to 1.76.x) #27869

merged 1 commit into from
Mar 1, 2025

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Feb 28, 2025 •
edited by kjozwiak
Loading

Uplift of #27836
Resolves brave/brave-browser#44272

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Feb 28, 2025
@Brandon-T Brandon-T self-assigned this Feb 28, 2025
@Brandon-T Brandon-T requested a review from a team as a code owner February 28, 2025 04:36
@kjozwiak kjozwiak added this to the 1.76.x - Release milestone Feb 28, 2025
@Brandon-T Brandon-T force-pushed the bugfix/TranslationDisabledFixes-1.76.x branch from 182523a to e925b7c Compare February 28, 2025 21:01
@Brandon-T
[iOS] - Fix Translation Onboarding on Disabled Pages (#27836)
bdd9c99 
* Fix a bug where pages can disable translation via html tags and the onboarding showed up.
* Fixed a bug where translate popup showed up when the script wasn't ready.
* Fixed a crash in PopoverController usage calling CheckedContinuation twice.
@Brandon-T Brandon-T force-pushed the bugfix/TranslationDisabledFixes-1.76.x branch from e925b7c to bdd9c99 Compare February 28, 2025 23:51
kjozwiak
kjozwiak approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.76.x approved 👍 QA has verified the PR on Nightly using 1.78.x as per #27836 (comment).

@kjozwiak kjozwiak merged commit 7a410b3 into 1.76.x Mar 1, 2025
16 checks passed
@kjozwiak kjozwiak deleted the bugfix/TranslationDisabledFixes-1.76.x branch March 1, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.76.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Brandon-T @kjozwiak