Skip to content

Commit

Permalink
Use std::optional
Browse files Browse the repository at this point in the history
  • Loading branch information
simonhong committed Dec 5, 2023
1 parent 221b946 commit 2484cff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions browser/onboarding/onboarding_tab_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ bool OnboardingTabHelper::IsSevenDaysPassedSinceFirstRun() {
}

// static
absl::optional<base::Time> OnboardingTabHelper::s_time_now_for_testing_;
absl::optional<base::Time> OnboardingTabHelper::s_sentinel_time_for_testing_;
std::optional<base::Time> OnboardingTabHelper::s_time_now_for_testing_;
std::optional<base::Time> OnboardingTabHelper::s_sentinel_time_for_testing_;

// static
void OnboardingTabHelper::MaybeCreateForWebContents(
Expand Down
6 changes: 3 additions & 3 deletions browser/onboarding/onboarding_tab_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
#ifndef BRAVE_BROWSER_ONBOARDING_ONBOARDING_TAB_HELPER_H_
#define BRAVE_BROWSER_ONBOARDING_ONBOARDING_TAB_HELPER_H_

#include <optional>
#include <string>

#include "base/time/time.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
#include "third_party/abseil-cpp/absl/types/optional.h"

class PrefRegistrySimple;

Expand Down Expand Up @@ -46,8 +46,8 @@ class OnboardingTabHelper

static bool IsSevenDaysPassedSinceFirstRun();

static absl::optional<base::Time> s_time_now_for_testing_;
static absl::optional<base::Time> s_sentinel_time_for_testing_;
static std::optional<base::Time> s_time_now_for_testing_;
static std::optional<base::Time> s_sentinel_time_for_testing_;

WEB_CONTENTS_USER_DATA_KEY_DECL();
};
Expand Down

0 comments on commit 2484cff

Please sign in to comment.