[ads] [[nodiscard]] code health

browser/ui/views/brave_ads/color_util.h

@@ -13,7 +13,7 @@
 namespace brave_ads {
 
 // Converts a string of the form "RRGGBB" to a `SkColor`.
-bool RgbStringToSkColor(std::string_view rgb, SkColor* color);
+[[nodiscard]] bool RgbStringToSkColor(std::string_view rgb, SkColor* color);
 
 }  // namespace brave_ads
 

components/brave_ads/browser/reminder/reminder_util.h

@@ -17,7 +17,7 @@ namespace brave_ads {
 
 base::Value::Dict BuildReminder(mojom::ReminderType mojom_reminder_type);
 
-bool IsReminder(const std::string& placement_id);
+[[nodiscard]] bool IsReminder(const std::string& placement_id);
 
 GURL GetReminderTargetUrl();
 

components/brave_ads/core/internal/account/account.h

@@ -39,7 +39,7 @@ class Account final : public AdsClientNotifierObserver,
   void AddObserver(AccountObserver* observer);
   void RemoveObserver(AccountObserver* observer);
 
-  bool IsUserRewardsSupported() const { return !!user_rewards_; }
+  [[nodiscard]] bool IsUserRewardsSupported() const { return !!user_rewards_; }
 
   void SetWallet(const std::string& payment_id,
                  const std::string& recovery_seed_base64);

components/brave_ads/core/internal/account/account_util.h

@@ -10,8 +10,9 @@
 
 namespace brave_ads {
 
-bool IsAllowedToDeposit(mojom::AdType mojom_ad_type,
-                        mojom::ConfirmationType mojom_confirmation_type);
+[[nodiscard]] bool IsAllowedToDeposit(
+    mojom::AdType mojom_ad_type,
+    mojom::ConfirmationType mojom_confirmation_type);
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/account/confirmations/queue/confirmation_queue.h

@@ -41,9 +41,9 @@ class ConfirmationQueue final : public AdsClientNotifierObserver,
   void AddCallback(const ConfirmationQueueItemInfo& confirmation_queue_item,
                    bool success);
 
-  bool ShouldProcessQueueItem(
+  [[nodiscard]] bool ShouldProcessQueueItem(
       const ConfirmationQueueItemInfo& confirmation_queue_item);
-  bool ShouldProcessBeforeScheduledQueueItem(
+  [[nodiscard]] bool ShouldProcessBeforeScheduledQueueItem(
       const ConfirmationQueueItemInfo& confirmation_queue_item);
   void ProcessQueueItemAfterDelay(
       const ConfirmationQueueItemInfo& confirmation_queue_item);

components/brave_ads/core/internal/account/issuers/issuers_util.h

@@ -15,10 +15,10 @@ struct IssuersInfo;
 void SetIssuers(const IssuersInfo& issuers);
 std::optional<IssuersInfo> GetIssuers();
 
-bool IsIssuersValid(const IssuersInfo& issuers);
+[[nodiscard]] bool IsIssuersValid(const IssuersInfo& issuers);
 
-bool HasIssuers();
-bool HasIssuersChanged(const IssuersInfo& other);
+[[nodiscard]] bool HasIssuers();
+[[nodiscard]] bool HasIssuersChanged(const IssuersInfo& other);
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/account/issuers/token_issuers/confirmation_token_issuer_util.h

@@ -10,7 +10,7 @@ namespace brave_ads {
 
 struct IssuersInfo;
 
-bool IsConfirmationTokenIssuerValid(const IssuersInfo& issuers);
+[[nodiscard]] bool IsConfirmationTokenIssuerValid(const IssuersInfo& issuers);
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/account/issuers/token_issuers/payment_token_issuer_util.h

@@ -10,7 +10,7 @@ namespace brave_ads {
 
 struct IssuersInfo;
 
-bool IsPaymentTokenIssuerValid(const IssuersInfo& issuers);
+[[nodiscard]] bool IsPaymentTokenIssuerValid(const IssuersInfo& issuers);
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/account/issuers/token_issuers/token_issuer_util.h

@@ -19,14 +19,15 @@ namespace cbr {
 class PublicKey;
 }  // namespace cbr
 
-bool TokenIssuerExistsForType(TokenIssuerType token_issuer_type);
+[[nodiscard]] bool TokenIssuerExistsForType(TokenIssuerType token_issuer_type);
 
 std::optional<TokenIssuerInfo> GetTokenIssuerForType(
     const IssuersInfo& issuers,
     TokenIssuerType token_issuer_type);
 
-bool TokenIssuerPublicKeyExistsForType(TokenIssuerType token_issuer_type,
-                                       const cbr::PublicKey& public_key);
+[[nodiscard]] bool TokenIssuerPublicKeyExistsForType(
+    TokenIssuerType token_issuer_type,
+    const cbr::PublicKey& public_key);
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/account/tokens/confirmation_tokens/confirmation_tokens.h

@@ -32,11 +32,12 @@ class ConfirmationTokens final {
   void Remove(const ConfirmationTokenList& confirmation_tokens);
   void RemoveAll();
 
-  bool Exists(const ConfirmationTokenInfo& confirmation_token) const;
+  [[nodiscard]] bool Exists(
+      const ConfirmationTokenInfo& confirmation_token) const;
 
   size_t Count() const;
 
-  bool IsEmpty() const;
+  [[nodiscard]] bool IsEmpty() const;
 
  private:
   ConfirmationTokenList confirmation_tokens_;

components/brave_ads/core/internal/account/tokens/confirmation_tokens/confirmation_tokens_util.h

@@ -25,9 +25,10 @@ bool RemoveConfirmationToken(const ConfirmationTokenInfo& confirmation_token);
 void RemoveConfirmationTokens(const ConfirmationTokenList& confirmation_tokens);
 void RemoveAllConfirmationTokens();
 
-bool ConfirmationTokenExists(const ConfirmationTokenInfo& confirmation_token);
+[[nodiscard]] bool ConfirmationTokenExists(
+    const ConfirmationTokenInfo& confirmation_token);
 
-bool ConfirmationTokensIsEmpty();
+[[nodiscard]] bool ConfirmationTokensIsEmpty();
 
 size_t ConfirmationTokenCount();
 

components/brave_ads/core/internal/account/tokens/payment_tokens/payment_token_util.h

@@ -23,9 +23,9 @@ bool RemovePaymentToken(const PaymentTokenInfo& payment_token);
 void RemovePaymentTokens(const PaymentTokenList& payment_tokens);
 void RemoveAllPaymentTokens();
 
-bool PaymentTokenExists(const PaymentTokenInfo& payment_token);
+[[nodiscard]] bool PaymentTokenExists(const PaymentTokenInfo& payment_token);
 
-bool PaymentTokensIsEmpty();
+[[nodiscard]] bool PaymentTokensIsEmpty();
 
 size_t PaymentTokenCount();
 

components/brave_ads/core/internal/account/tokens/payment_tokens/payment_tokens.h

@@ -32,11 +32,11 @@ class PaymentTokens final {
   void RemoveTokens(const PaymentTokenList& payment_tokens);
   void RemoveAllTokens();
 
-  bool TokenExists(const PaymentTokenInfo& payment_token);
+  [[nodiscard]] bool TokenExists(const PaymentTokenInfo& payment_token);
 
   size_t Count() const;
 
-  bool IsEmpty() const;
+  [[nodiscard]] bool IsEmpty() const;
 
  private:
   PaymentTokenList payment_tokens_;

components/brave_ads/core/internal/account/transactions/reconciled_transactions_util.h

@@ -14,12 +14,15 @@ class Time;
 
 namespace brave_ads {
 
-bool DidReconcileTransaction(const TransactionInfo& transaction);
-bool DidReconcileTransactionsPreviousMonth(const TransactionList& transactions);
-bool DidReconcileTransactionsThisMonth(const TransactionList& transactions);
-bool DidReconcileTransactionWithinDateRange(const TransactionInfo& transaction,
-                                            base::Time from_time,
-                                            base::Time to_time);
+[[nodiscard]] bool DidReconcileTransaction(const TransactionInfo& transaction);
+[[nodiscard]] bool DidReconcileTransactionsPreviousMonth(
+    const TransactionList& transactions);
+[[nodiscard]] bool DidReconcileTransactionsThisMonth(
+    const TransactionList& transactions);
+[[nodiscard]] bool DidReconcileTransactionWithinDateRange(
+    const TransactionInfo& transaction,
+    base::Time from_time,
+    base::Time to_time);
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/account/utility/refill_confirmation_tokens/refill_confirmation_tokens.h

@@ -44,7 +44,7 @@ class RefillConfirmationTokens final {
 
   void GenerateTokens();
 
-  bool ShouldRequestSignedTokens() const;
+  [[nodiscard]] bool ShouldRequestSignedTokens() const;
   void RequestSignedTokens();
   void RequestSignedTokensCallback(
       const mojom::UrlResponseInfo& mojom_url_response);

components/brave_ads/core/internal/account/utility/refill_confirmation_tokens/refill_confirmation_tokens_util.h

@@ -10,7 +10,7 @@
 
 namespace brave_ads {
 
-bool ShouldRefillConfirmationTokens();
+[[nodiscard]] bool ShouldRefillConfirmationTokens();
 
 size_t CalculateAmountOfConfirmationTokensToRefill();
 

components/brave_ads/core/internal/ad_units/creative_ad_cache.cc

@@ -13,7 +13,7 @@ namespace brave_ads {
 
 namespace {
 
-bool IsValid(const CreativeAdVariant& creative_ad_variant) {
+[[nodiscard]] bool IsValid(const CreativeAdVariant& creative_ad_variant) {
   return absl::visit(
       base::Overloaded{
           [](const mojom::CreativeSearchResultAdInfoPtr& mojom_creative_ad)

components/brave_ads/core/internal/ad_units/notification_ad/notification_ad_handler_util.h

@@ -8,12 +8,12 @@
 
 namespace brave_ads {
 
-bool ShouldServe();
+[[nodiscard]] bool ShouldServe();
 
-bool CanServeIfUserIsActive();
+[[nodiscard]] bool CanServeIfUserIsActive();
 
-bool CanServeAtRegularIntervals();
-bool ShouldServeAtRegularIntervals();
+[[nodiscard]] bool CanServeAtRegularIntervals();
+[[nodiscard]] bool ShouldServeAtRegularIntervals();
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/ads_client/ads_client_pref_provider.h

@@ -29,11 +29,13 @@ class AdsClientPrefProvider : public PrefProviderInterface {
 
   std::optional<base::Value> GetProfilePref(
       const std::string& pref_path) const override;
-  bool HasProfilePrefPath(const std::string& pref_path) const override;
+  [[nodiscard]] bool HasProfilePrefPath(
+      const std::string& pref_path) const override;
 
   std::optional<base::Value> GetLocalStatePref(
       const std::string& pref_path) const override;
-  bool HasLocalStatePrefPath(const std::string& pref_path) const override;
+  [[nodiscard]] bool HasLocalStatePrefPath(
+      const std::string& pref_path) const override;
 
   std::optional<base::Value> GetVirtualPref(
       const std::string& pref_path) const override;

components/brave_ads/core/internal/application_state/browser_manager.h

@@ -28,9 +28,11 @@ class BrowserManager final : public AdsClientNotifierObserver {
   void AddObserver(BrowserManagerObserver* observer);
   void RemoveObserver(BrowserManagerObserver* observer);
 
-  bool IsActive() const { return is_active_.value_or(false); }
+  [[nodiscard]] bool IsActive() const { return is_active_.value_or(false); }
 
-  bool IsInForeground() const { return is_in_foreground_.value_or(false); }
+  [[nodiscard]] bool IsInForeground() const {
+    return is_in_foreground_.value_or(false);
+  }
 
  private:
   void NotifyBrowserDidBecomeActive() const;

components/brave_ads/core/internal/application_state/browser_util.h

@@ -19,7 +19,7 @@ class ScopedBrowserVersionNumberForTesting final {
   ~ScopedBrowserVersionNumberForTesting();
 };
 
-bool WasBrowserUpgraded();
+[[nodiscard]] bool WasBrowserUpgraded();
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/catalog/campaign/creative_set/catalog_creative_set_info.h

@@ -33,7 +33,7 @@ struct CatalogCreativeSetInfo final {
   bool operator==(const CatalogCreativeSetInfo&) const;
   bool operator!=(const CatalogCreativeSetInfo&) const;
 
-  bool DoesSupportOS() const;
+  [[nodiscard]] bool DoesSupportOS() const;
 
   std::string id;
   int per_day = 0;

components/brave_ads/core/internal/catalog/catalog.cc

@@ -23,7 +23,7 @@ namespace brave_ads {
 
 namespace {
 
-bool DoesRequireResourceForNewTabPageAds() {
+[[nodiscard]] bool DoesRequireResourceForNewTabPageAds() {
   // Require resource only if:
   // - The user has opted into new tab page ads and either joined Brave Rewards
   //   or new tab page ad events should always be triggered.
@@ -32,7 +32,7 @@ bool DoesRequireResourceForNewTabPageAds() {
           ShouldAlwaysTriggerNewTabPageAdEvents());
 }
 
-bool DoesRequireResource() {
+[[nodiscard]] bool DoesRequireResource() {
   // Require resource only if:
   // - The user has opted into Brave News ads.
   // - The user has opted into new tab page ads and has either joined Brave

components/brave_ads/core/internal/catalog/catalog_util.h

@@ -34,9 +34,9 @@ void SetCatalogPing(base::TimeDelta ping);
 base::Time GetCatalogLastUpdated();
 void SetCatalogLastUpdated(base::Time last_updated_at);
 
-bool DoesCatalogExist();
-bool HasCatalogChanged(const std::string& catalog_id);
-bool HasCatalogExpired();
+[[nodiscard]] bool DoesCatalogExist();
+[[nodiscard]] bool HasCatalogChanged(const std::string& catalog_id);
+[[nodiscard]] bool HasCatalogExpired();
 
 }  // namespace brave_ads
 

components/brave_ads/core/internal/common/challenge_bypass_ristretto/batch_dleq_proof.h

@@ -42,7 +42,7 @@ class BatchDLEQProof {
   bool operator==(const BatchDLEQProof&) const;
   bool operator!=(const BatchDLEQProof&) const;
 
-  bool has_value() const {
+  [[nodiscard]] bool has_value() const {
     return batch_dleq_proof_ && batch_dleq_proof_.has_value();
   }
 

components/brave_ads/core/internal/common/challenge_bypass_ristretto/blinded_token.h

@@ -38,7 +38,7 @@ class BlindedToken {
   bool operator==(const BlindedToken&) const;
   bool operator!=(const BlindedToken&) const;
 
-  bool has_value() const {
+  [[nodiscard]] bool has_value() const {
     return blinded_token_ && blinded_token_.has_value();
   }
 

components/brave_ads/core/internal/common/challenge_bypass_ristretto/public_key.h

@@ -34,7 +34,7 @@ class PublicKey {
   bool operator==(const PublicKey&) const;
   bool operator!=(const PublicKey&) const;
 
-  bool has_value() const { return public_key_.has_value(); }
+  [[nodiscard]] bool has_value() const { return public_key_.has_value(); }
 
   challenge_bypass_ristretto::PublicKey& get() {
     CHECK(public_key_);

components/brave_ads/core/internal/common/challenge_bypass_ristretto/signed_token.h

@@ -36,7 +36,7 @@ class SignedToken {
   bool operator==(const SignedToken&) const;
   bool operator!=(const SignedToken&) const;
 
-  bool has_value() const { return signed_token_.has_value(); }
+  [[nodiscard]] bool has_value() const { return signed_token_.has_value(); }
 
   challenge_bypass_ristretto::SignedToken& get() {
     CHECK(signed_token_);

components/brave_ads/core/internal/common/challenge_bypass_ristretto/signing_key.h

@@ -39,7 +39,7 @@ class SigningKey {
   bool operator==(const SigningKey&) const;
   bool operator!=(const SigningKey&) const;
 
-  bool has_value() const { return signing_key_.has_value(); }
+  [[nodiscard]] bool has_value() const { return signing_key_.has_value(); }
 
   challenge_bypass_ristretto::SigningKey& get() {
     CHECK(signing_key_);

components/brave_ads/core/internal/common/challenge_bypass_ristretto/token.h

@@ -38,7 +38,7 @@ class Token {
   bool operator==(const Token&) const;
   bool operator!=(const Token&) const;
 
-  bool has_value() const { return token_.has_value(); }
+  [[nodiscard]] bool has_value() const { return token_.has_value(); }
 
   challenge_bypass_ristretto::Token& get() {
     CHECK(token_);

components/brave_ads/core/internal/common/challenge_bypass_ristretto/token_preimage.h

@@ -37,7 +37,7 @@ class TokenPreimage {
   bool operator==(const TokenPreimage&) const;
   bool operator!=(const TokenPreimage&) const;
 
-  bool has_value() const {
+  [[nodiscard]] bool has_value() const {
     return token_preimage_ && token_preimage_.has_value();
   }
 

components/brave_ads/core/internal/common/challenge_bypass_ristretto/unblinded_token.h

@@ -41,7 +41,7 @@ class UnblindedToken {
   bool operator==(const UnblindedToken&) const;
   bool operator!=(const UnblindedToken&) const;
 
-  bool has_value() const {
+  [[nodiscard]] bool has_value() const {
     return unblinded_token_ && unblinded_token_.has_value();
   }
 

components/brave_ads/core/internal/common/challenge_bypass_ristretto/verification_signature.h

@@ -38,7 +38,7 @@ class VerificationSignature {
   bool operator==(const VerificationSignature&) const;
   bool operator!=(const VerificationSignature&) const;
 
-  bool has_value() const {
+  [[nodiscard]] bool has_value() const {
     return verification_signature_ && verification_signature_.has_value();
   }
 

components/brave_ads/core/internal/common/country_code/country_code.cc

@@ -20,7 +20,7 @@ namespace brave_ads {
 
 namespace {
 
-bool DoesSupportCountryCode() {
+[[nodiscard]] bool DoesSupportCountryCode() {
   return UserHasJoinedBraveRewards();
 }
 

components/brave_ads/core/internal/common/database/database_transaction_util.h

@@ -17,7 +17,7 @@
 namespace brave_ads::database {
 
 // Returns true if the transaction result is a success.
-bool IsTransactionSuccessful(
+[[nodiscard]] bool IsTransactionSuccessful(
     const mojom::DBTransactionResultInfoPtr& mojom_db_transaction_result);
 
 // Run a database transaction. The callback takes one argument -