Skip to content

Commit

Permalink
[Android] Modularize bookmarks browser code
Browse files Browse the repository at this point in the history
Chromium change:
https://chromium.googlesource.com/chromium/src/+/088816e5c47905f8b4e16dd867cddaf24fb4f55f

[bookmarks] Modularize bookmarks browser code

Moved production bookmarks browser code to chrome/browser/bookmarks
directory. Made some small changes along the way to simplify the
process.
* Moved all production bookmarks browser code to module.
* Added a separate target for files that can be modularized now.
* Added a separate gni list for files that can't be modularized now
  which is included in chrome_java directly. Over time I will refactor
  those files so that they are moved into the main modularized target.
* Merged ReadingListUtils and BookmarkUtils. In the long run, browser
  reading list code shouldn't really exist since the concepts are
  merged at the native level.
* Moved one method from BookmarkUtils to BookmarkModel to allow for
  more files to be modularized.

Eventually some files, particularly implementations of interfaces
defined in chrome/browser/bookmarks, will live in the unmodularized
directory.

Bug: 395908100
  • Loading branch information
samartnik committed Feb 21, 2025
1 parent d7e2528 commit d098ee0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions build/android/bytecode/bytecode_rewriter.gni
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ brave_bytecode_jars = [
"obj/chrome/android/base_module_java.javac.jar",
"obj/chrome/android/chrome_java.javac.jar",
"obj/chrome/android/features/tab_ui/java.javac.jar",
"obj/chrome/browser/bookmarks/android/java.javac.jar",
"obj/chrome/browser/download/internal/android/java.javac.jar",
"obj/chrome/browser/flags/java.javac.jar",
"obj/chrome/browser/hub/internal/java.javac.jar",
Expand Down
1 change: 1 addition & 0 deletions test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1289,6 +1289,7 @@ if (is_android) {
"//chrome/browser/android/browserservices/intents:java",
"//chrome/browser/android/lifecycle:java",
"//chrome/browser/back_press/android:java",
"//chrome/browser/bookmarks/android:java",
"//chrome/browser/browser_controls/android:java",
"//chrome/browser/contextmenu:java",
"//chrome/browser/data_sharing:data_sharing_public_java",
Expand Down

0 comments on commit d098ee0

Please sign in to comment.