-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parallel import #15674
Merged
Merged
Added parallel import #15674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b561d6
to
50ca195
Compare
a410be0
to
d76b831
Compare
65f8c60
to
acf34fd
Compare
simonhong
reviewed
Oct 31, 2022
27cdd40
to
9f5420c
Compare
9f5420c
to
0b73226
Compare
simonhong
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ with some nits! 👍🏼
simonhong
reviewed
Nov 1, 2022
0b73226
to
41d5257
Compare
simonhong
reviewed
Nov 1, 2022
browser/ui/webui/settings/brave_full_disk_access_confirm_dialog_delegate.h
Outdated
Show resolved
Hide resolved
c50a981
to
9ca059a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26282
For new onboarding brave/brave-browser#26378 we have to be able to run imports from multiple browsers with one click. Chromium has single import implementation and we added opportunity to run multiple imports simultaneously.
BraveImportDataHandler
instead of separate file to be able to run new import.FullDiskAccessConfirmDialogDelegate
to separate files, NO CHANGES inside.brave-import-data-status-changed
with detailed information about the progress.kParallelImports
feature to disable new code until Update onboarding to new design and flow brave-browser#26378 landed, because it is not compatible with old way and replaces it. @nullhook will remove this flag and enable new code in that PR.IMPORTANT!: New code is disabled now by
kParallelImports
feature flag, it will be enabled by @nullhook in his PR brave/brave-browser#26378.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: