-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced chrome dark logo with channel product logo from settings drawer menu #20215
Conversation
@rebron this looks fine? |
Should we use the Gear icon for Settings instead? |
@simonhong can you use the regular Brave logo in dark mode too? |
Ok, I'll try to put per-channel brave icon there. |
@simonhong, can't we just copy our own svg over the upstream one in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonhong in your opinion, is this patch better than overwriting the file from util.js | updateBranding
?
10a290f
to
09fdb2b
Compare
09fdb2b
to
2e38cc6
Compare
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#31355 (comment), ensured that the
|
fix brave/brave-browser#31355
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: