-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NTP Next] Prototype #27228
Draft
zenparsing
wants to merge
1
commit into
master
Choose a base branch
from
ksmith-ntp-next-draft
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[NTP Next] Prototype #27228
+11,018
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a622e4
to
d001c5c
Compare
A Storybook has been deployed to preview UI for the latest push |
be9011a
to
3fb6d9e
Compare
Chromium major version is behind target branch (132.0.6834.83 vs 133.0.6943.27). Please rebase. |
3fb6d9e
to
1c5a6f5
Compare
084692d
to
9b3f146
Compare
f4c6949
to
296891a
Compare
browser/resources/brave_new_tab_page_refresh/components/background.tsx
Fixed
Show resolved
Hide resolved
151916d
to
3e7ecae
Compare
3e7ecae
to
f30731b
Compare
Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase. |
f30731b
to
a4f1625
Compare
0213a1a
to
5565daf
Compare
5565daf
to
e1dec73
Compare
e1dec73
to
881dbfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
CI/storybook-url
Deploy storybook and provide a unique URL for each build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the latest draft work on the NTP next feature.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: