Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using profile's url loader instead of system. #27595

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Feb 10, 2025

Resolves https://github.com/brave/internal/issues/1249
Resolves brave/brave-browser#44334

https://chromium-review.googlesource.com/c/chromium/src/+/6269498

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@boocmp boocmp requested a review from darkdh February 10, 2025 11:42
@boocmp boocmp self-assigned this Feb 10, 2025
@boocmp boocmp marked this pull request as ready for review February 10, 2025 13:34
@boocmp boocmp requested review from a team as code owners February 10, 2025 13:34
@darkdh darkdh requested a review from bridiver February 10, 2025 17:09
@boocmp boocmp force-pushed the internal/issues/1249 branch from 180c041 to df4f0c4 Compare February 11, 2025 02:58
@darkdh
Copy link
Member

darkdh commented Feb 11, 2025

@bridiver mentioned we should figure out why they used system url loader in the first place or try to upstream the fix.

Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@boocmp boocmp force-pushed the internal/issues/1249 branch from df4f0c4 to 91a17a2 Compare February 28, 2025 01:21
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 28, 2025
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as this is uplift of a landed upstream.

@boocmp boocmp merged commit 3d612ab into master Feb 28, 2025
20 checks passed
@boocmp boocmp deleted the internal/issues/1249 branch February 28, 2025 10:48
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Feb 28, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[security] internal issue 1249
4 participants