-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using profile's url loader instead of system. #27595
Merged
Merged
+243
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
reviewed
Feb 10, 2025
patches/content-browser-webauth-webauth_request_security_checker.cc.patch
Outdated
Show resolved
Hide resolved
patches/content-browser-webauth-webauth_request_security_checker.h.patch
Outdated
Show resolved
Hide resolved
180c041
to
df4f0c4
Compare
@bridiver mentioned we should figure out why they used system url loader in the first place or try to upstream the fix. |
Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase. |
df4f0c4
to
91a17a2
Compare
darkdh
approved these changes
Feb 28, 2025
goodov
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as this is uplift of a landed upstream.
Released in v1.78.6 |
brave-builds
added a commit
that referenced
this pull request
Mar 2, 2025
7 tasks
brave-builds
added a commit
that referenced
this pull request
Mar 2, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/brave/internal/issues/1249
Resolves brave/brave-browser#44334
https://chromium-review.googlesource.com/c/chromium/src/+/6269498
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: