[ads] Suppress RichNTT if brave://settings/content/javascript is disabled

[tmancey]

Resolves brave/brave-browser#43655

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Confirm rich media NTTs are shown if brave://settings/content/javascript is enable and not shown if disabled.

[kylehickinson]

iOS++

[diracdeltas]

i would add a manual test plan that toggling brave://settings/content/javascript on and off works as expected but otherwise lgtm

[tmancey]

i would add a manual test plan that toggling brave://settings/content/javascript on and off works as expected but otherwise lgtm

Just finishing adding the tests, and thank you.

[github-actions]

[puLL-Merge] - brave/brave-core@27783

Here's my analysis of this pull request:

Description

This PR modifies the Brave browser codebase to respect JavaScript content settings when displaying sponsored rich media content in new tab takeovers. It adds logic to check if JavaScript is enabled before allowing rich media wallpapers, while still allowing image-based wallpapers regardless of JavaScript settings. The PR also includes significant refactoring of related components and test improvements.

Changes

Changes

By filename:

1. browser/brave_ads/ads_service_factory.cc:

   • Adds HostContentSettingsMap dependency to AdsService

2. components/brave_ads/browser/ads_service_impl.cc:

   • Implements JavaScript content settings check
   • Adds observer for content settings changes
   • Updates prefetch logic based on content settings

3. components/ntp_background_images/:

   • Adds wallpaper type distinction between image and rich media
   • Updates logic to filter rich media content based on JavaScript settings
   • Improves testing coverage around content settings

4. Database changes:

   • Adds 'type' column to creative_new_tab_page_ads table
   • Updates schema version to 49
   • Adds migration logic for existing data

sequenceDiagram
    participant User
    participant Browser
    participant ContentSettings
    participant AdsService
    participant Database

    User->>Browser: Opens New Tab
    Browser->>ContentSettings: Check JavaScript settings
    ContentSettings->>AdsService: Allow/Block rich media
    AdsService->>Database: Query eligible wallpapers
    Database->>AdsService: Return filtered wallpapers
    AdsService->>Browser: Return appropriate wallpaper
    Browser->>User: Display wallpaper

Loading

Security Hotspots

1. Content Settings Validation:

   • The PR correctly implements content setting checks for JavaScript, but special attention should be paid to ensuring these checks cannot be bypassed

2. Database Migration:

   • The migration for schema v49 sets default type to 'image' for existing records
   • Migration path needs to be carefully tested to avoid data corruption