Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wknapik test #27796

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

wknapik test #27796

wants to merge 1 commit into from

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Feb 25, 2025

DO NOT REVIEW
DO NOT MERGE

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) CI/skip-teamcity Do not run builds in TeamCity labels Feb 25, 2025
@wknapik wknapik self-assigned this Feb 25, 2025
@wknapik wknapik requested a review from bsclifton as a code owner February 25, 2025 15:17
@wknapik wknapik added CI/skip-teamcity Do not run builds in TeamCity and removed CI/skip-teamcity Do not run builds in TeamCity labels Feb 25, 2025
@wknapik wknapik force-pushed the wknapik-generic-testing01 branch from db25f8b to f84422b Compare February 26, 2025 15:03
@wknapik wknapik added CI/skip-teamcity Do not run builds in TeamCity and removed CI/skip-teamcity Do not run builds in TeamCity CI/skip Do not run CI builds (except noplatform) labels Feb 26, 2025
@wknapik wknapik force-pushed the wknapik-generic-testing01 branch 2 times, most recently from 378684e to 67d57d2 Compare February 27, 2025 18:38
@wknapik wknapik requested a review from a team as a code owner February 27, 2025 18:38
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 27, 2025
@wknapik wknapik force-pushed the wknapik-generic-testing01 branch 3 times, most recently from c59ac7d to e95e4cb Compare February 28, 2025 03:49
@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) and removed CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Feb 28, 2025
@wknapik wknapik requested a review from a team as a code owner February 28, 2025 11:48
@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) and removed CI/skip Do not run CI builds (except noplatform) labels Feb 28, 2025
@wknapik wknapik force-pushed the wknapik-generic-testing01 branch from b8a9797 to e3c3241 Compare February 28, 2025 17:40
@wknapik wknapik marked this pull request as draft February 28, 2025 17:40
@wknapik wknapik removed CI/skip-teamcity Do not run builds in TeamCity CI/skip Do not run CI builds (except noplatform) labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant