Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cursor is not changed to resize when hovered to sidebar resize area #27841

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 27, 2025

fix brave/brave-browser#43507

We use control widget for resize handle in side panel to receive input event over webview.
On macOS, it seems current cursor is not cleared when mouse goes out in some situation unexpectedly.
Widget doesn't change its current cursor if it's same with requested one.
So, we can see resize cursor only once. To fix, clear current cursor manually.
Maybe this problem happens because it's located above WebView.
If ResizeHandle is inside the other views control, this is not happened.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Move mouse around the side panel's resizable area and check cursor is changed as resize cursor.

…area

fix brave/brave-browser#43507

On macOS, previous cursor is not cleared when mouse goes out.
So, we can see resize cursor only once. To fix, clear current cursor
manually. Widget doesn't change its current cursor if it's same with
requested one.
@simonhong simonhong self-assigned this Feb 27, 2025
@simonhong simonhong marked this pull request as ready for review February 27, 2025 08:19
@simonhong simonhong requested a review from boocmp February 27, 2025 08:20
@simonhong simonhong merged commit 8355412 into master Feb 27, 2025
19 checks passed
@simonhong simonhong deleted the fix_resize_cursor_side_panel branch February 27, 2025 12:37
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Feb 27, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resize sidebar panels properly
3 participants