Fixed cursor is not changed to resize when hovered to sidebar resize area #27841
+35
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#43507
We use control widget for resize handle in side panel to receive input event over webview.
On macOS, it seems current cursor is not cleared when mouse goes out in some situation unexpectedly.
Widget doesn't change its current cursor if it's same with requested one.
So, we can see resize cursor only once. To fix, clear current cursor manually.
Maybe this problem happens because it's located above WebView.
If ResizeHandle is inside the other views control, this is not happened.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Move mouse around the side panel's resizable area and check cursor is changed as resize cursor.