Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves BraveMediaNotificationControllerServices class into a base module #27860

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Feb 27, 2025

The PR moves BraveMediaNotificationControllerServices to the base module of bundles, similar to upstream's ChromeMediaNotificationControllerServices
Resolves brave/brave-browser#44302

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I couldn't replicate it. For some reason some devices require that some services were in the base module. That feature with Brave Talk keep mic and audio when phone is locked basically migrated through all channels, has been verified a few times and we didn't see any issues. To verify just simply make sure that Brave Talk meeting links are functional.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Feb 27, 2025
@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 27, 2025
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner February 27, 2025 22:33
@@ -6,11 +6,9 @@
# You can obtain one at https://mozilla.org/MPL/2.0/. */


# Here we can extend the list of non-base services that are allowed to be included in the app bundle.
# Here we can extend the list of non-base services that are allowed to be
# included in the app bundle.
def extend_allowlisted_non_base_services(allowlisted_non_base_services):
allowlisted_non_base_services.add(
'com.brave.playlist.playback_service.VideoPlaybackService')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeppandya we probably need to move it to the base module as well once feature is ready for release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergeyZhukovsky

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -6,11 +6,9 @@
# You can obtain one at https://mozilla.org/MPL/2.0/. */


# Here we can extend the list of non-base services that are allowed to be included in the app bundle.
# Here we can extend the list of non-base services that are allowed to be
# included in the app bundle.
def extend_allowlisted_non_base_services(allowlisted_non_base_services):
allowlisted_non_base_services.add(
'com.brave.playlist.playback_service.VideoPlaybackService')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergeyZhukovsky

@SergeyZhukovsky SergeyZhukovsky merged commit 02f227c into master Feb 28, 2025
19 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_media_notification_service branch February 28, 2025 14:16
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Feb 28, 2025
brave-builds added a commit that referenced this pull request Feb 28, 2025
brave-builds added a commit that referenced this pull request Feb 28, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.7

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.78.7 Chromium: 134.0.6998.39 (Official Build) canary (64-bit)
--- | ---
Revision | 777512a9a91ee8924ddb909a5d25a86ef7fcd93f
OS | Android 15; Build/AP4A.250205.002; 35; REL

Using https://kjozwiak.github.io, clicked on several of the Brave Talk Links and ensured everything loaded without any issues. Also ensured that going to talk.brave.com and starting a Free Conversation/Call worked without issues as per the following:

screen-20250228-183159.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash Unable to create service org.chromium.chrome.browser.media.ui.BraveMediaNotificationControllerServices
7 participants