-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves BraveMediaNotificationControllerServices class into a base module #27860
Conversation
@@ -6,11 +6,9 @@ | |||
# You can obtain one at https://mozilla.org/MPL/2.0/. */ | |||
|
|||
|
|||
# Here we can extend the list of non-base services that are allowed to be included in the app bundle. | |||
# Here we can extend the list of non-base services that are allowed to be | |||
# included in the app bundle. | |||
def extend_allowlisted_non_base_services(allowlisted_non_base_services): | |||
allowlisted_non_base_services.add( | |||
'com.brave.playlist.playback_service.VideoPlaybackService') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deeppandya we probably need to move it to the base module as well once feature is ready for release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SergeyZhukovsky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -6,11 +6,9 @@ | |||
# You can obtain one at https://mozilla.org/MPL/2.0/. */ | |||
|
|||
|
|||
# Here we can extend the list of non-base services that are allowed to be included in the app bundle. | |||
# Here we can extend the list of non-base services that are allowed to be | |||
# included in the app bundle. | |||
def extend_allowlisted_non_base_services(allowlisted_non_base_services): | |||
allowlisted_non_base_services.add( | |||
'com.brave.playlist.playback_service.VideoPlaybackService') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SergeyZhukovsky
Released in v1.78.7 |
Verification PASSED on
Using https://kjozwiak.github.io, clicked on several of the screen-20250228-183159.mp4 |
The PR moves
BraveMediaNotificationControllerServices
to the base module of bundles, similar to upstream'sChromeMediaNotificationControllerServices
Resolves brave/brave-browser#44302
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
I couldn't replicate it. For some reason some devices require that some services were in the base module. That feature with Brave Talk keep mic and audio when phone is locked basically migrated through all channels, has been verified a few times and we didn't see any issues. To verify just simply make sure that Brave Talk meeting links are functional.