[CodeHealth] Simplifying json parsing - pt.4

[cdesouza-chromium]

This PR simplifies JSON reading in several places by:

- Using `base::JSONReader::ReadDict`
- Using `base::JSONReader::ReadList`
- Using `base::test::ParseJson*`

This changes aim to make the checks around the parsing and its expectations simpler to read.

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[iefremov]

components/skus/renderer lgtm

[supermassive]

I think we don't need to test non-dict inputs as it is validated by caller now

[cdesouza-chromium]

Done. Thanks.

[supermassive]

wallet core lgtm

[github-actions]

[puLL-Merge] - brave/brave-core@27884

Description

This PR updates the codebase to use the new Value API in Chromium's base library, specifically transitioning from the older JSONReader::Read() to the newer base::test::ParseJson() and JSONReader::ReadDict() methods. The changes are focused on modernizing JSON parsing across several Brave components and improving type safety.

Changes

Changes

1. components/brave_wallet/

   • Replaced base::JSONReader::Read with base::test::ParseJson in test files
   • Updated CompareJSON function to use newer APIs
   • Modified function signatures to accept base::Value::Dict directly
   • Updated parameter types for parsing functions to work with dictionary values directly

2. components/de_amp/

   • Updated navigation chain handling to use List APIs directly
   • Switched to base::JSONReader::ReadDict for JSON parsing

3. Other Components

   • Updated JSON parsing in ntp_background_images, psst, request_otr, skus and web_discovery components
   • Removed redundant dictionary type checking
   • Simplified error handling paths by using newer APIs

sequenceDiagram
    participant App
    participant JSONParser
    participant Dict
    
    App->>JSONParser: ReadDict(json_string)
    alt Invalid JSON
        JSONParser-->>App: Return nullopt
    else Valid JSON
        JSONParser->>Dict: Create Dictionary
        Dict-->>App: Return Dict
    end
    
    App->>Dict: Access Values
    Dict-->>App: Return Typed Values

Loading

Details

The key changes involve:

1. Replacing base::JSONReader::Read() with:

   • base::test::ParseJson() for testing
   • base::JSONReader::ReadDict() for production code
   • base::JSONReader::ReadList() where lists are expected

2. Modifying function signatures to work with base::Value::Dict directly rather than raw base::Value

3. Removing redundant type checking since the new APIs enforce types at the API level