-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Wallet) Load Meld icons correctly in Buy WebUI #27885
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Wallet Front-end
@@ -77,6 +78,8 @@ AndroidWalletPageUI::AndroidWalletPageUI(content::WebUI* web_ui, | |||
base::CommandLine::ForCurrentProcess()->HasSwitch( | |||
brave_wallet::mojom::kP3ACountTestNetworksSwitch)); | |||
|
|||
content::URLDataSource::Add(profile, | |||
std::make_unique<SanitizedImageSource>(profile)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need data
or chrome://erc-token-images
in https://github.com/brave/brave-core/pull/27885/files#diff-0e0eb6acfeba674a0c6a698e22c04773ae563f8629ac3841fc1ec59b6d3e5b02R71 above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diracdeltas, I confirm both data:
and chrome://erc-token-images
are still needed for the Android Wallet.
data:
is still required to load correctly brave://wallet/crypto/fund-wallet
, without it TestMeldPageAppearing fails.
chrome://erc-token-images
is still required to load correctly brave://wallet/crypto/deposit-funds
, without it TestDepositPageAppearing fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Resolves brave/brave-browser#44321
In
android_wallet_page_ui.cc
registers sanitized image source data source to servechrome://image
URLs.android_wallet_page_ui.cc
contains Android-specific implementation and should follow the same approach ofwallet_page_ui.cc
for registering the required data sources.SanitizedImageSource
is in charge of providing the source ofchrome://image
that is referenced bychrome::kChromeUIImageHost
constant.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: