[Local AI] [WebSpeech] Serve Web Speech sessions from Brave's own model - #39398
Draft
yrliou wants to merge 1 commit into
Draft
[Local AI] [WebSpeech] Serve Web Speech sessions from Brave's own model#39398yrliou wants to merge 1 commit into
yrliou wants to merge 1 commit into
Conversation
Contributor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| if (enable_local_ai) { | ||
| brave_content_browser_sources += [ | ||
| "//brave/content/browser/speech/brave_on_device_speech_recognition_engine.cc", |
Contributor
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] New source files should not be added to sources.gni. Please see https://github.com/brave/brave-core/blob/master/docs/gni_sources.md for details
Source: https://github.com/brave/security-action/blob/main/assets/opengrep_rules/client/sources_gni.yaml
Cc @brave/sources-gni-reviewers
| if (enable_local_ai) { | ||
| brave_content_browser_sources += [ | ||
| "//brave/content/browser/speech/brave_on_device_speech_recognition_engine.cc", | ||
| "//brave/content/browser/speech/brave_on_device_speech_recognition_engine.h", |
Contributor
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] New source files should not be added to sources.gni. Please see https://github.com/brave/brave-core/blob/master/docs/gni_sources.md for details
Source: https://github.com/brave/security-action/blob/main/assets/opengrep_rules/client/sources_gni.yaml
Cc @brave/sources-gni-reviewers
yrliou
force-pushed
the
stt-pr2-engine
branch
3 times, most recently
from
August 26, 2026 23:37
1a21c45 to
212a87c
Compare
Upstream decides a session is on-device in two places, and failing either sends it to SODA or to the speech recognition service, bypassing the browser. Both now accept the qualities Brave's model serves, and that path builds a subclass taking its stream from Brave's worker rather than a ModelBroker session. `AudioChunksEnded` closes the input stream but keeps the responder bound, since the worker emits its final result on that close and upstream's immediate empty result would end recognition first. No UI thread Core is built, because it would ask the optimization guide broker for assets nothing here uses. `ContentBrowserClient` gains `GetAsrSession` so content can reach the embedder without depending on Brave. The controller refuses a session when no model is installed, surfacing as a recognition failure rather than a worker that cannot load.
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. |
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream decides a session is on-device in two places, and failing either sends it to SODA or to the speech recognition service, bypassing the browser. Both now accept the qualities Brave's model serves, and that path builds a subclass taking its stream from Brave's worker rather than a ModelBroker session.
AudioChunksEndedcloses the input stream but keeps the responder bound, since the worker emits its final result on that close and upstream's immediate empty result would end recognition first. No UI thread Core is built, because it would ask the optimization guide broker for assets nothing here uses.ContentBrowserClientgainsGetAsrSessionso content can reach the embedder without depending on Brave. The controller refuses a session when no model is installed, surfacing as a recognition failure rather than a worker that cannot load.