[Local AI] [WebSpeech] Install Brave's own model for on-device speech recognition - #39399
Draft
yrliou wants to merge 1 commit into
Draft
[Local AI] [WebSpeech] Install Brave's own model for on-device speech recognition#39399yrliou wants to merge 1 commit into
yrliou wants to merge 1 commit into
Conversation
yrliou
force-pushed
the
stt-pr3-installer
branch
from
August 25, 2026 23:14
c924fce to
13719de
Compare
Contributor
📋 Code Owners Summary17 file(s) changed, 8 with assigned owners 3 team(s) affected: Owners and Their Files
|
yrliou
force-pushed
the
stt-pr3-installer
branch
from
August 26, 2026 00:16
13719de to
d86937a
Compare
yrliou
force-pushed
the
stt-pr3-installer
branch
from
August 26, 2026 17:14
d86937a to
8fee7f8
Compare
yrliou
force-pushed
the
stt-pr3-installer
branch
from
August 26, 2026 23:37
8fee7f8 to
616890d
Compare
Availability and install stay with upstream's `OnDeviceSpeechRecognitionImpl`, so the pieces it consults are replaced instead. Availability answers terminally because Brave ships no SODA and no optimization guide model, and the requested quality is normalised so both entry points take the SODA branch. The global `SodaInstaller` is replaced by a subclass installing Brave's component. It derives from `SodaInstaller`, not the desktop implementation whose delivery acts on SODA's own ids, directories and preferences, so a new pure virtual becomes a compile error rather than inherited behaviour. `install()` parks its reply so every path reports one. The component updater is watched too, because startup registration asks for the same download, drops its callback, and its failure is reported nowhere else. Only `kUpdateError` is taken: success arrives via `ComponentReady`, and intermediate states stay unreported so `IsSodaLanguageDownloading` stays false.
yrliou
force-pushed
the
stt-pr3-installer
branch
from
August 26, 2026 23:57
616890d to
e8c7a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Availability and install stay with upstream's
OnDeviceSpeechRecognitionImpl, so the pieces it consults are replaced instead. Availability answers terminally because Brave ships no SODA and no optimization guide model, and the requested quality is normalised so both entry points take the SODA branch.The global
SodaInstalleris replaced by a subclass installing Brave's component. It derives fromSodaInstaller, not the desktop implementation whose delivery acts on SODA's own ids, directories and preferences, so a new pure virtual becomes a compile error rather than inherited behaviour.install()parks its reply so every path reports one. The component updater is watched too, because startup registration asks for the same download, drops its callback, and its failure is reported nowhere else. OnlykUpdateErroris taken: success arrives viaComponentReady, and intermediate states stay unreported soIsSodaLanguageDownloadingstays false.