[ads] Add enable Sponsored Ads setting to privacy settings on iOS - #39419
[ads] Add enable Sponsored Ads setting to privacy settings on iOS#39419aseren wants to merge 1 commit into
Conversation
The PR adds an `Enable Sponsored Ads` toggle to the `Other privacy settings` section of `Brave Shields & Privacy` settings page on iOS.
| title: Strings.Settings.sponsoredAdsEnabledTitle, | ||
| subtitle: Strings.Settings.sponsoredAdsEnabledDescription, | ||
| toggle: Binding( | ||
| get: { Preferences.NewTabPage.backgroundMediaType.isSponsored }, |
There was a problem hiding this comment.
Preferences.NewTabPage.backgroundMediaType is a Swift preference which controls brave_ads.sponsored.enabled chromium pref under the hood.
I will migrate it to a new Preferences.SponsoredAds.enabled Swift preference in a follow-up.
|
This doesn't seem like a good place for this preference |
@kylehickinson, for desktop it is added to "Data collection" section of Privacy settings, along with P3A, diagnostic report and daily usage ping which are placed under Corresponding section in spec: https://docs.google.com/document/d/1AVrttOOaUe3jCbW9qqVVflAbq5A3KrXONPdyENAEb4o/edit?tab=t.2vdgigrj6db2#heading=h.yh5idlhcvlzn Desktop looks like: |
3 participants
The PR adds an
Enable Sponsored Adstoggle to theOther privacy settingssection ofBrave Shields & Privacysettings page on iOS.Screenshot of "Brave Shields & Privacy" settings page on iOS:
Enable Sponsored Contenttoggle toData Collectionunder settings brave-browser#57204